From 0d1c4d1514b0e4cafe77ecd214534486b7e41be3 Mon Sep 17 00:00:00 2001
From: Fabien <metalua@gmail.com>
Date: Tue, 4 Oct 2011 14:54:08 +0200
Subject: [PATCH] generic support for tag modifiers; modifiers "opt" and
 "optchain" for tag "param"

---
 ldoc/doc.lua   | 25 ++++++++++++++++++++++---
 ldoc/parse.lua | 29 ++++++++++++++++++++++-------
 2 files changed, 44 insertions(+), 10 deletions(-)

diff --git a/ldoc/doc.lua b/ldoc/doc.lua
index a0de22f..fcc8fc0 100644
--- a/ldoc/doc.lua
+++ b/ldoc/doc.lua
@@ -292,9 +292,14 @@ function Item:finish()
          params = tags.field or List()
       end
       tags.param = nil
-      local names,comments = List(),List()
+      local names, comments, modifiers = List(), List(), List()
       for p in params:iter() do
-         local name,comment = p:match('%s*([%w_%.:]+)(.*)')
+         local line, mods
+         if type(p)=='string' then line, mods = p, { }
+         else line, mods = p[1], p.modifiers or { } end 
+         modifiers:append(mods)
+         local name, comment = line :match('%s*([%w_%.:]+)(.*)')
+         assert(name, "bad param name format")
          names:append(name)
          comments:append(comment)
       end
@@ -310,10 +315,24 @@ function Item:finish()
          end
       end
       self.params = names
+      self.modifiers = modifiers
       for i,name in ipairs(self.params) do
          self.params[name] = comments[i]
       end
-      self.args = '('..self.params:join(', ')..')'
+      local buffer, npending = { }, 0
+      local function acc(x) table.insert(buffer, x) end
+      for i = 1, #names  do
+        local m = modifiers[i]
+        if not m.optchain then
+            acc ((']'):rep(npending))
+            npending=0
+        end
+        if m.opt or m.optchain then acc('['); npending=npending+1 end
+        if i>1 then acc (', ') end
+        acc(names[i])
+      end
+      acc ((']'):rep(npending))
+      self.args = '('..table.concat(buffer)..')'
    end
 end
 
diff --git a/ldoc/parse.lua b/ldoc/parse.lua
index 4ffbb4b..ea34ae9 100644
--- a/ldoc/parse.lua
+++ b/ldoc/parse.lua
@@ -18,6 +18,7 @@ local tnext, append = lexer.skipws, table.insert
 -- followed by the value, which may extend over several lines.
 local luadoc_tag = '^%s*@(%a+)'
 local luadoc_tag_value = luadoc_tag..'(.*)'
+local luadoc_tag_mod_and_value = luadoc_tag..'%[(.*)%](.*)'
 
 -- assumes that the doc comment consists of distinct tag lines
 function parse_tags(text)
@@ -26,9 +27,21 @@ function parse_tags(text)
    local tag_items = {}
    local follows
    while line do
-      local tag,rest = line:match(luadoc_tag_value)
+      local tag, mod_string, rest = line :match(luadoc_tag_mod_and_value)
+      if not tag then tag, rest = line :match (luadoc_tag_value) end
+      local modifiers
+      if mod_string then
+         modifiers  = { }
+         for x in mod_string :gmatch "[^,]+" do
+            local k, v = x :match "^([^=]+)=(.*)$"
+            if not k then k, v = x, x end
+            modifiers[k] = v
+         end
+      end
+      -- follows: end of current tag
+      -- line: beginning of next tag (for next iteration)
       follows, line = tools.grab_while_not(lines,luadoc_tag)
-      append(tag_items,{tag, rest .. '\n' .. follows})
+      append(tag_items,{tag, rest .. '\n' .. follows, modifiers})
    end
    return preamble,tag_items
 end
@@ -53,16 +66,18 @@ local function extract_tags (s)
    end  --  and strip(description) ?
    local tags = {summary=summary and strip(summary) or '',description=description or ''}
    for _,item in ipairs(tag_items) do
-      local tag,value = item[1],item[2]
+      local tag, value, modifiers = unpack(item)
       tag = Item.check_tag(tags,tag)
       value = strip(value)
+      if modifiers then value = { value, modifiers=modifiers } end
       local old_value = tags[tag]
 
-      if old_value then
-         if type(old_value)=='string' then tags[tag] = List{old_value} end
-         tags[tag]:append(value)
-      else
+      if not old_value then -- first element
          tags[tag] = value
+      elseif type(old_value)=='table' and old_value.append then -- append to existing list 
+         old_value :append (value)      
+      else -- upgrade string->list
+         tags[tag] = List{old_value, value}
       end
    end
    return Map(tags)