Aire-One
/
awesome
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FS#996: awful.ewmh: Connect to property::border_width signal 

For example, I have some lua code which sets the border width based on the
number of visible clients. When just a single client is visible, the border
width is 0, else it's what the theme says.

Previously, this caused visible "glitches" for fullscreen'd and maximized
clients. This patch fixes that and updates the client's geometry and
border width appropriately.

This has a slight chance of going into an endless loop if someone sets a
fullscreen'd clients border width from its property::border_width signal.
Just don't do that!

Thanks to Arvydas Sidorenko for finding this issue.

Signed-off-by: Uli Schlachter <psychon@znc.in>
This commit is contained in:
Uli Schlachter 2012-05-16 23:03:32 +02:00
parent 4170c77a08
commit 3cbb59b0dc
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/awful/ewmh.lua.in
View File

@ -112,9 +112,29 @@ local function screen_change(window)
end end
end end
-- Update a client's settings when its border width changes
local function border_change(window)
-- Fix up the geometry in case this window needs to cover the whole screen.
local bw = window.border_width or 0
local g = screen[window.screen].workarea
if window.maximized_vertical then
window:geometry { height = g.height - 2*bw, y = g.y }
end
if window.maximized_horizontal then
window:geometry { height = g.height - 2*bw, y = g.y }
end
if window.fullscreen then
-- This *will* cause an endless loop if some other property::border_width
-- signal dares to change the border width, too, so don't do that!
window.border_width = 0
window:geometry(screen[window.screen].geometry)
end
end
client.connect_signal("request::maximized_horizontal", maximized_horizontal) client.connect_signal("request::maximized_horizontal", maximized_horizontal)
client.connect_signal("request::maximized_vertical", maximized_vertical) client.connect_signal("request::maximized_vertical", maximized_vertical)
client.connect_signal("request::fullscreen", fullscreen) client.connect_signal("request::fullscreen", fullscreen)
client.connect_signal("property::screen", screen_change) client.connect_signal("property::screen", screen_change)
client.connect_signal("property::border_width", border_change)
-- vim: filetype=lua:expandtab:shiftwidth=4:tabstop=8:softtabstop=4:textwidth=80 -- vim: filetype=lua:expandtab:shiftwidth=4:tabstop=8:softtabstop=4:textwidth=80