Aire-One
/
awesome
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Get properly windows geometry when handling existing windows at Awesome startup

This commit is contained in:
Arnaud Fontaine 2008-03-27 05:12:39 +00:00 committed by Julien Danjou
parent cd42cda9d4
commit 6db3cd48d8
1 changed files with 53 additions and 88 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

145
awesome.c
View File

@ -66,124 +66,89 @@ static bool running = true;
AwesomeConf globalconf; AwesomeConf globalconf;
/** Get geometry informations like XCB version, and also set 'x' and
* 'y' parameter on its parent window like Xlib does
*
* TODO: improve round-trip time?
*/
static xcb_get_geometry_reply_t *
x_get_geometry(xcb_connection_t *c, xcb_window_t w, xcb_get_geometry_reply_t *parent)
{
xcb_get_geometry_reply_t *win_geom;
win_geom = xcb_get_geometry_reply(c, xcb_get_geometry(c, w), NULL);
if(!win_geom)
return NULL;
/* Unlike XCB, Xlib set 'x' and 'y' as parent window position */
win_geom->x = parent->x;
win_geom->y = parent->y;
return win_geom;
}
typedef struct typedef struct
{ {
xcb_get_geometry_cookie_t geom; xcb_window_t id;
xcb_query_tree_cookie_t tree; xcb_query_tree_cookie_t tree_cookie;
} screen_win_t; } root_win_t;
/** Scan X to find windows to manage /** Scan X to find windows to manage
*/ */
static void static void
scan() scan()
{ {
unsigned int i; int i, screen, real_screen;
int screen, real_screen;
xcb_window_t w;
xcb_window_t *wins = NULL;
xcb_query_tree_reply_t *r_query_tree;
xcb_get_geometry_reply_t *parent_geom, *win_geom;
xcb_get_window_attributes_reply_t *reply_win;
xcb_get_window_attributes_cookie_t *cookies_win;
const int screen_max = xcb_setup_roots_length(xcb_get_setup(globalconf.connection)); const int screen_max = xcb_setup_roots_length(xcb_get_setup(globalconf.connection));
screen_win_t *parents = alloca(sizeof(screen_win_t) * screen_max); root_win_t *root_wins = alloca(sizeof(root_win_t) * screen_max);
xcb_query_tree_reply_t *tree_r;
xcb_window_t *wins = NULL;
xcb_get_window_attributes_cookie_t *attr_wins = NULL;
xcb_get_window_attributes_reply_t *attr_r;
xcb_get_geometry_reply_t *geom_r;
for(screen = 0; screen < screen_max; screen++) for(screen = 0; screen < screen_max; screen++)
{ {
w = xutil_root_window(globalconf.connection, screen); root_wins[screen].id = xutil_root_window(globalconf.connection, screen);
/* Get parent geometry informations, useful to get the real
* coordinates of the window because Xlib set 'x' and 'y'
* fields to the relative position within the parent window */
parents[screen].geom = xcb_get_geometry(globalconf.connection, w);
/* Get the window tree */ /* Get the window tree */
parents[screen].tree = xcb_query_tree_unchecked(globalconf.connection, w); root_wins[screen].tree_cookie = xcb_query_tree_unchecked(globalconf.connection,
root_wins[screen].id);
} }
for(screen = 0; screen < screen_max; screen++) for(screen = 0; screen < screen_max; screen++)
{ {
parent_geom = xcb_get_geometry_reply (globalconf.connection, tree_r = xcb_query_tree_reply(globalconf.connection,
parents[screen].geom, NULL); root_wins[screen].tree_cookie,
if(!parent_geom)
continue;
r_query_tree = xcb_query_tree_reply(globalconf.connection,
parents[screen].tree, NULL);
if(!r_query_tree)
{
p_delete(&parent_geom);
continue;
}
wins = xcb_query_tree_children(r_query_tree);
/* Store the answers of 'xcb_get_window_attributes' for all
* child windows */
cookies_win = p_new(xcb_get_window_attributes_cookie_t,
r_query_tree->children_len);
/* Send all the requests at the same time */
for(i = 0; i < r_query_tree->children_len; i++)
cookies_win[i] = xcb_get_window_attributes(globalconf.connection, wins[i]);
/* Now process the answers */
for(i = 0; i < r_query_tree->children_len; i++)
{
reply_win = xcb_get_window_attributes_reply(globalconf.connection,
cookies_win[i],
NULL); NULL);
if(reply_win && !reply_win->override_redirect && if(!tree_r)
(reply_win->map_state == XCB_MAP_STATE_VIEWABLE || continue;
wins = xcb_query_tree_children(tree_r);
attr_wins = p_new(xcb_get_window_attributes_cookie_t,
xcb_query_tree_children_length(tree_r));
for(i = 0; i < xcb_query_tree_children_length(tree_r); i++)
attr_wins[i] = xcb_get_window_attributes_unchecked(globalconf.connection,
wins[i]);
for(i = 0; i < xcb_query_tree_children_length(tree_r); i++)
{
attr_r = xcb_get_window_attributes_reply(globalconf.connection,
attr_wins[i],
NULL);
if(!attr_r || attr_r->override_redirect ||
!(attr_r->map_state == XCB_MAP_STATE_VIEWABLE ||
window_getstate(wins[i]) == XCB_WM_ICONIC_STATE)) window_getstate(wins[i]) == XCB_WM_ICONIC_STATE))
{ {
/* TODO: should maybe be asynchronous */ if(attr_r)
win_geom = x_get_geometry(globalconf.connection, w, parent_geom); p_delete(&attr_r);
if(!win_geom)
{
p_delete(&reply_win);
continue; continue;
} }
real_screen = screen_get_bycoord(globalconf.screens_info, screen, win_geom->x, win_geom->y); p_delete(&attr_r);
client_manage(wins[i], win_geom, real_screen);
/* win_geom is not useful anymore */ /* TODO: should maybe be asynchronous... */
p_delete(&win_geom); geom_r = xcb_get_geometry_reply(globalconf.connection,
xcb_get_geometry_unchecked(globalconf.connection,
wins[i]),
NULL);
if(!geom_r)
continue;
real_screen = screen_get_bycoord(globalconf.screens_info, screen, geom_r->x,
geom_r->y);
client_manage(wins[i], geom_r, real_screen);
p_delete(&geom_r);
} }
if(reply_win) p_delete(&tree_r);
p_delete(&reply_win); p_delete(&attr_wins);
}
p_delete(&parent_geom);
p_delete(&r_query_tree);
p_delete(&cookies_win);
} }
} }