Merge pull request #716 from psychon/wallpaper_cleanup

Wallpaper cleanup

lib/gears/surface.lua

@@ -41,8 +41,6 @@ function surface.load_uncached_silently(_surface, default)
     if not _surface then
         return get_default(default)
     end
-    -- Remove from cache if it was cached
-    surface_cache[_surface] = nil
     -- lgi cairo surfaces don't get changed either
     if cairo.Surface:is_type_of(_surface) then
         return _surface
@@ -57,12 +55,7 @@ function surface.load_uncached_silently(_surface, default)
         end
     end
     -- Everything else gets forced into a surface
-    _surface = cairo.Surface(_surface, true)
+    return cairo.Surface(_surface, true)
-    -- If we loaded a file, cache it
-    if file then
-        surface_cache[file] = _surface
-    end
-    return _surface
 end
 
 --- Try to convert the argument into an lgi cairo surface.
@@ -80,6 +73,12 @@ function surface.load_silently(_surface, default)
         if cache then
             return cache
         end
+        local result, err = surface.load_uncached_silently(_surface, default)
+        if not err then
+            -- Cache the file
+            surface_cache[_surface] = result
+        end
+        return result, err
     end
     return surface.load_uncached_silently(_surface, default)
 end

lib/gears/wallpaper.lua

@@ -61,6 +61,7 @@ function wallpaper.prepare_context(s)
             local paper = pending_wallpaper
             pending_wallpaper = nil
             wallpaper.set(paper)
+            paper:finish()
         end)
     else
         -- Draw to the already-pending wallpaper
@@ -99,7 +100,7 @@ end
 --   gears.color. The default is black.
 function wallpaper.centered(surf, s, background)
     local geom, cr = wallpaper.prepare_context(s)
-    surf = surface(surf)
+    surf = surface.load_uncached(surf)
     background = color(background)
 
     -- Fill the area with the background
@@ -114,6 +115,7 @@ function wallpaper.centered(surf, s, background)
     cr:clip()
     cr:set_source_surface(surf, 0, 0)
     cr:paint()
+    surf:finish()
 end
 
 --- Set a tiled wallpaper.
@@ -128,11 +130,13 @@ function wallpaper.tiled(surf, s, offset)
         cr:translate(offset.x, offset.y)
     end
 
-    local pattern = cairo.Pattern.create_for_surface(surface(surf))
+    surf = surface.load_uncached(surf)
+    local pattern = cairo.Pattern.create_for_surface(surf)
     pattern.extend = cairo.Extend.REPEAT
     cr.source = pattern
     cr.operator = cairo.Operator.SOURCE
     cr:paint()
+    surf:finish()
 end
 
 --- Set a maximized wallpaper.
@@ -144,7 +148,7 @@ end
 -- @param offset This can be set to a table with entries x and y.
 function wallpaper.maximized(surf, s, ignore_aspect, offset)
     local geom, cr = wallpaper.prepare_context(s)
-    surf = surface(surf)
+    surf = surface.load_uncached(surf)
     local w, h = surface.get_size(surf)
     local aspect_w = geom.width / w
     local aspect_h = geom.height / h
@@ -166,6 +170,7 @@ function wallpaper.maximized(surf, s, ignore_aspect, offset)
     cr:set_source_surface(surf, 0, 0)
     cr.operator = cairo.Operator.SOURCE
     cr:paint()
+    surf:finish()
 end
 
 --- Set a fitting wallpaper.
@@ -176,7 +181,7 @@ end
 --   gears.color. The default is black.
 function wallpaper.fit(surf, s, background)
     local geom, cr = wallpaper.prepare_context(s)
-    surf = surface(surf)
+    surf = surface.load_uncached(surf)
     background = color(background)
 
     -- Fill the area with the background
@@ -196,6 +201,7 @@ function wallpaper.fit(surf, s, background)
     cr:scale(scale, scale)
     cr:set_source_surface(surf, 0, 0)
     cr:paint()
+    surf:finish()
 end
 
 return wallpaper