f3ee880bd8
Merge pull request #2816 from Elv13/more_notif_fix
...
Fix 4 "new API" notification bugs
2019-07-10 17:27:27 -04:00
12f1908ef8
notification: Make the position index more robust.
...
If the notification screen or position changed, it would end up in the
wrong index and removing it would fail. This cannot happen anymore.
2019-07-09 02:31:18 -04:00
def76356c4
doc updates for naughty
2019-07-07 12:32:03 +05:30
c47402d002
doc: Add an image for the position of naughty.layout.legacy
2019-06-08 18:56:08 -04:00
9a7a313719
naughty: Destroy the notification when an action is executed.
...
Whoops, I changed the name of the method at some point and never
updated this instance. It was also not clausing the notification
like people expect.
2019-06-08 18:56:08 -04:00
4aaf6ea730
naughty: Only enable the legacy mode when there is no other handlers.
...
It was called legacy for a reason, it is meant to be used only when the
rc.lua doesn't have the newer notification section.
2019-06-08 18:56:08 -04:00
44e9ecdd30
naughty: Add an awful.widget.common based "notification list"
...
This layout allows to place a list of notifications in a wibar or popup.
2019-06-08 18:56:08 -04:00
d8d80ec69a
naughty: Add the `awful.popup` based notification `box`
...
It replaces the legacy box popup.
2019-06-08 18:56:08 -04:00
916b49bde0
naughty: Add an actionlist widget.
...
This widget allows to use the actions without all the boilerplate
code associated with managing a list.
2019-06-08 18:56:08 -04:00
f1dceb02f6
doc: Move all popups to a section.
2019-06-08 18:13:42 -04:00
9e2a544ba3
naughty: Add position "middle" to center notifications in screen ( #2775 )
...
Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
2019-06-08 16:10:14 -04:00
63e7c68b6c
Fix the broken test due to the "soft" merge conflict of two notification pull requests. ( #2751 )
...
* naughty.legacy: Fix a regression caused by a prior fix.
The title was only set "later" because it was called too early.
The intended result was to prevent the code from being executed when
there is no leagcy popup, but it had this side effect.
* naughty.dbus: Expose the new "private" methods so they can be tested.
Because it now uses Gio instead of capi.dbus, it isn't possible to
just shim the backend anymore.
* shims: Upgrade the dbus shims to also emulate some Gio behavior.
As usual, it is the most basic version that produces the correct
result. It doesn't try to comply to the real API.
2019-04-15 13:07:53 -04:00
dc1f87ef84
Merge pull request #2738 from Elv13/doc_tests_and_notif_p5_1
...
Split the reviewed groundwork commits from the notification widgets pull request
2019-04-13 12:57:58 -04:00
dce1830b89
naughty: Fix a rebase mistake when using actions.
...
Some older revisions called it `trigger` instead of `invoke`.
Apparently some rebase conflicts introduced the old name in
merged code.
See #2729
2019-04-05 22:20:16 -04:00
d99f8461ef
naughty.legacy: Do not update the text if the notification has no widget
...
If the notification has been created without a legacy widget, it would
try to update some widgets that have never been created.
2019-04-05 21:06:11 -04:00
494474ba0a
naughty: Resize notification when setting text
2019-02-23 18:54:39 +01:00
8072d717cf
Fix extra newline with legacy naughty layout
...
Fixes 9df77e5c76 (commitcomment-32354198)
2019-02-18 08:34:59 +01:00
7c96a98a0d
naughty: Correctly update the content of the legacy popup
2019-02-16 15:49:39 -05:00
e13b9a48ff
naughty: Use same object when the remote source request a replacement
...
Previously, it would create a new object. The leaves the old
`replaces_id` logic mostly intact for now to keep the full backward
compatibility. I don't think anybody would have noticed the changed, by
time and time again we had proof that some silent users have some
amazing and advanced code hidden somewhere. It could be cleaned later
when breaking compatibility isn't an issue.
2019-02-16 15:49:39 -05:00
1b567cc06a
notification: Rename text to message
...
There is many "text" and the default text is the title, not the body.
2019-02-16 15:26:38 -05:00
6d5d016a2a
naughty: Turn actions into object.
...
The current API is non-compliant with the 1.0 spec and cannot represent
the v1.2 spec at all. The pair of name and callback fails to represent
the explicit ordering and cannot support the icons cleanly.
Plus to support the keyboard navigation use case, the notification
action need to be able to get some sort of focus state. Having an
object makes this easy.
2019-02-16 15:26:38 -05:00
e70822a6a4
naughty: Make sure the icon cannot be bigger then the box.
...
Without this change, parts of the icon were hidden.
2019-02-16 15:26:38 -05:00
bfda6f64bb
naughty: Display the notification with invalid icons.
...
They previously caused an error.
2019-02-16 15:26:38 -05:00
9df77e5c76
naughty: Move the notification object into its own file.
...
Mostly for the documentation, but also as the new base upon which
to build the modular notification GUI.
2019-02-16 15:25:10 -05:00
Emmanuel Lepage Vallée
Vishnunarayan K I
Michael Beaumont
Alphonse Mariya
Daniel Hahler