Commit Graph

22 Commits

Author SHA1 Message Date
Romanos Skiadas 4bc22fbb70 mpris-widget: delete on mouse::enter code
this code is janky, because the notification is set asynchronously, it
can end up not being cleaned by the mouse exit and then you can end up
with multiple ones. Also, the image field of the table needs to be icon,
but if the icon is an http url like some players print or even a local
file like firefox does, setting the icon causes an error as it can't be
read.
2021-10-16 09:59:03 +03:00
Romanos Skiadas ca08528926 mpris-widget: correct artUrl
Perhaps due to the regex change, or maybe it never did work, art was always
nil. Use gears.string.split(), which works, is much easier to read than the
regex and removes the need to munge the artUrl after too.
2021-10-15 18:47:11 +03:00
Romanos Skiadas 567b5bb84f mpris-widget: make play/pause icon work
The middle part of mpris_widget was meant to be a play/pause icon. It
only displayed a circle, as an unrelated widget that was not shown was
set up and modified according to the play state. Delete the invisible
widget, add the icon where it should be.
2021-10-15 18:34:09 +03:00
Romanos Skiadas aacbf61fac mpris-widget: enable notification on mouse enter
use the right widget and it just works(TM). Changed the title to not
have bold formatting, as it's already formatted and the <b> was printed
literally, changed the <b>by</b> to - as it looks nicer to me.
2021-10-15 18:23:26 +03:00
Romanos Skiadas 2b829c7257 mpris-widget: remove more dead code
no need to update a widget that is never updated
2021-10-15 18:18:30 +03:00
Romanos Skiadas 588227cc1a mpris-widget: rename mpdstatus to player_status 2021-10-15 17:51:59 +03:00
Romanos Skiadas 435d5d14f8 mpris-widget: fix api call
there is no naughty.notification, notify returns a notification
2021-10-15 17:51:59 +03:00
Romanos Skiadas c5852546ae mpris-widget: correctly clean list of players
Do it outside the loop, otherwise the last player wins.
2021-10-15 17:51:59 +03:00
Romanos Skiadas db0b3e9e8c mpris-widget: fix incorrect boolean expression
the loop is not meant to be executed if the player name is nil or '', so
the expression needs to be an and.
2021-10-15 17:51:59 +03:00
Romanos Skiadas 2755f85623 mpris-widget: remove some dead code
the mpdarc widget is not really used and is a copy-paste leftover. The
current widget has its own bindings already.
2021-10-15 17:51:59 +03:00
Romanos Skiadas 540d5edb5f mpris-widget: fix capture regex for playerctl output
Before, the table ended up being something like {"status", "",
"artist", "", ..}, so the output of the widget was garbled.
2021-08-23 11:20:27 +03:00
Romanos Skiadas cede33fa3f mpris-widget: fix call to set_text
.set_text is invalid, it should be :set_text like in the other branches
of the if.
2021-08-23 11:20:08 +03:00
Romanos Skiadas cdeed22ba5 mpris-widget: fix README, typo 2021-08-23 11:19:33 +03:00
streetturtle 8ad4d0228d fix build 2020-12-17 15:27:00 -05:00
streetturtle baa9177b70 ultimate volume widget improvements 2020-12-14 22:33:56 -05:00
streetturtle a0cd854a4d fix more warnings 2020-12-05 20:57:04 -05:00
gaberm 062a6d7762 Added image icon for streaming from firefox 2020-11-25 23:11:32 +02:00
mgabs de14c1325f
Merge branch 'master' into pr-213 2020-11-23 21:19:52 +02:00
gaberm 5dbfab7248 added icon to mpris popup 2020-11-23 21:03:06 +02:00
streetturtle 30199568c6 wrap widget in a function 2020-11-23 09:55:37 -05:00
gaberm 0e1d31ad6f Fixed notify status - mpris widget 2020-11-21 14:45:37 +02:00
gaberm c95ff15ab4 adding an mpris widget 2020-11-16 21:38:16 +02:00