From 1309287ead4784bb1a32180b3e60eac2fab7deeb Mon Sep 17 00:00:00 2001 From: Arnaud Fontaine Date: Fri, 28 Mar 2008 21:59:05 +0000 Subject: [PATCH] Cleanup of TODO messages --- event.c | 6 +++--- ewmh.c | 4 ---- mouse.c | 14 ++++---------- 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/event.c b/event.c index cece209c8..951870821 100644 --- a/event.c +++ b/event.c @@ -579,9 +579,9 @@ event_handle_randr_screen_change_notify(void *data __attribute__ ((unused)), xcb_randr_set_screen_size(connection, ev->root, ev->width, ev->height, ev->mwidth, ev->mheight); - /* TODO: - * XRRUpdateConfiguration also executes the following instruction - * but I don't know yet how to port it to XCB + /* XRRUpdateConfiguration also executes the following instruction + * but it's not useful because SubpixelOrder is not used at all at + * the moment * * XRenderSetSubpixelOrder(dpy, snum, scevent->subpixel_order); */ diff --git a/ewmh.c b/ewmh.c index 222ad6892..d3042f0c2 100644 --- a/ewmh.c +++ b/ewmh.c @@ -357,7 +357,6 @@ ewmh_process_client_message(xcb_client_message_event_t *ev) Client *c; int screen; - /* TODO: check whether it's correct to use 'type' this way */ if(ev->type == net_current_desktop) for(screen = 0; screen < xcb_setup_roots_length(xcb_get_setup(globalconf.connection)); @@ -377,9 +376,6 @@ ewmh_process_client_message(xcb_client_message_event_t *ev) if((c = client_get_bywin(globalconf.clients, ev->window))) { ewmh_process_state_atom(c, (xcb_atom_t) ev->data.data32[1], ev->data.data32[0]); - /* TODO: is data32[2] really useful because it doesn't - * seem to be used when sending a ClientMessage in - * event.c:897 */ if(ev->data.data32[2]) ewmh_process_state_atom(c, (xcb_atom_t) ev->data.data32[2], ev->data.data32[0]); diff --git a/mouse.c b/mouse.c index 3babe9e85..f9d99b0f5 100644 --- a/mouse.c +++ b/mouse.c @@ -191,11 +191,8 @@ uicb_client_movemouse(int screen, char *arg __attribute__ ((unused))) for(;;) { - /* TODO: need a review - * - * XMaskEvent allows to retrieve only specified events from - * the queue and requeue the other events... - */ + /* XMaskEvent allows to retrieve only specified events from + * the queue and requeue the other events... */ while((ev = xcb_poll_for_event(globalconf.connection))) { switch((ev->response_type & 0x7f)) @@ -389,11 +386,8 @@ uicb_client_resizemouse(int screen, char *arg __attribute__ ((unused))) for(;;) { - /* TODO: need a review - * - * XMaskEvent allows to retrieve only specified events from - * the queue and requeue the other events... - */ + /* XMaskEvent allows to retrieve only specified events from + * the queue and requeue the other events... */ while((ev = xcb_poll_for_event(globalconf.connection))) { switch((ev->response_type & 0x7f))