awesomewm-mirrors
/
awesome
mirror of https://github.com/awesomeWM/awesome.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

placement: Handle when the preferred position isn't set. 

This removes a FIXME from the code.
This commit is contained in:
Emmanuel Lepage Vallee 2019-03-04 15:19:16 -05:00
parent 3ff795b4fc
commit 29d89c5e8a
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/awful/placement.lua
View File

@ -1484,7 +1484,11 @@ function placement.next_to(d, args)
does_fit[pos.name] = fit and {geo, dir} or nil does_fit[pos.name] = fit and {geo, dir} or nil
if fit and preferred_positions[pos.name] and preferred_positions[pos.name] < pref_idx then -- preferred_positions is optional
local better_pos_idx = preferred_positions[pos.name]
and preferred_positions[pos.name] < pref_idx or false
if fit and (better_pos_idx or not pref_name) then
pref_idx = preferred_positions[pos.name] pref_idx = preferred_positions[pos.name]
pref_name = pos.name pref_name = pos.name
end end
@ -1493,7 +1497,11 @@ function placement.next_to(d, args)
if fit then break end if fit then break end
end end
local ngeo, dir = unpack(does_fit[pref_name] or {}) --FIXME why does this happen if not pref_name then return end
assert(does_fit[pref_name])
local ngeo, dir = unpack(does_fit[pref_name])
-- The requested placement isn't possible due to the lack of space, better -- The requested placement isn't possible due to the lack of space, better
-- do nothing an try random things -- do nothing an try random things