From 2ebd1202239a90586e907323ec5ff6b264419c49 Mon Sep 17 00:00:00 2001 From: Uli Schlachter Date: Mon, 20 Aug 2018 10:28:21 +0200 Subject: [PATCH] Refactor event_handle_configurerequest Before this commit, the code in here first handled clients changing its x/y position and afterwards it handled resizes. This meant that the special case of "client resizes without moving itself so we need to apply gravity" had to have special checks on whether the client moved itself or not. Change the code so that resizes are handled first and moves later. This naturally handles the problem: If the client resizes and moves itself, the move done for the resize is later overwritten when the move is handled. No functional changes are intended. Signed-off-by: Uli Schlachter --- event.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/event.c b/event.c index 9ab676538..29bcbe8d0 100644 --- a/event.c +++ b/event.c @@ -343,16 +343,6 @@ event_handle_configurerequest(xcb_configure_request_event_t *ev) lua_State *L = globalconf_get_lua_State(); - if(ev->value_mask & XCB_CONFIG_WINDOW_X) - { - geometry.x = ev->x; - xwindow_translate_for_gravity(c->size_hints.win_gravity, deco_left, 0, deco_right, 0, &geometry.x, NULL); - } - if(ev->value_mask & XCB_CONFIG_WINDOW_Y) - { - geometry.y = ev->y; - xwindow_translate_for_gravity(c->size_hints.win_gravity, 0, deco_top, 0, deco_bottom, NULL, &geometry.y); - } if(ev->value_mask & XCB_CONFIG_WINDOW_WIDTH) { uint16_t old_w = geometry.width; @@ -383,12 +373,17 @@ event_handle_configurerequest(xcb_configure_request_event_t *ev) /* If the client resizes without moving itself, apply window gravity */ if(c->size_hints.flags & XCB_ICCCM_SIZE_HINT_P_WIN_GRAVITY) { - int16_t diff_x = 0, diff_y = 0; - xwindow_translate_for_gravity(c->size_hints.win_gravity, diff_border, diff_border, diff_w, diff_h, &diff_x, &diff_y); - if(!(ev->value_mask & XCB_CONFIG_WINDOW_X)) - geometry.x += diff_x; - if(!(ev->value_mask & XCB_CONFIG_WINDOW_Y)) - geometry.y += diff_y; + xwindow_translate_for_gravity(c->size_hints.win_gravity, diff_border, diff_border, diff_w, diff_h, &geometry.x, &geometry.y); + } + if(ev->value_mask & XCB_CONFIG_WINDOW_X) + { + geometry.x = ev->x; + xwindow_translate_for_gravity(c->size_hints.win_gravity, deco_left, 0, deco_right, 0, &geometry.x, NULL); + } + if(ev->value_mask & XCB_CONFIG_WINDOW_Y) + { + geometry.y = ev->y; + xwindow_translate_for_gravity(c->size_hints.win_gravity, 0, deco_top, 0, deco_bottom, NULL, &geometry.y); } c->got_configure_request = true;