awesomewm-mirrors
/
awesome
mirror of https://github.com/awesomeWM/awesome.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove obsolete entries from check_for_invalid_requires.lua (#1673) 

Most of the entries that are marked as "TODO: Get rid of these" were
handled. wibox.layout.align:get_children() never worked (it always
called a non-existent function), so we can easily fix this entry without
introducing a regression.

I opened https://github.com/awesomeWM/awesome/issues/1672 to track the
underlying problem behind the broken :get_children() function (which is
missing test coverage).

Signed-off-by: Uli Schlachter <psychon@znc.in>
This commit is contained in:
Uli Schlachter 2017-03-26 21:20:18 +02:00 committed by Emmanuel Lepage Vallée
parent b3d1114e88
commit 3bda88ff64
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
build-utils/check_for_invalid_requires.lua
View File

@ -48,11 +48,6 @@ local allowed_deps = {
wibox = true,
},
-- TODO: Get rid of these
["beautiful.xresources"] = { ["awful.util"] = true },
["gears.object"] = { ["awful.util"] = true },
["wibox.container"] = { ["awful.util"] = true },
["wibox.layout"] = { ["awful.util"] = true },
["wibox.widget"] = { ["awful.util"] = true },
["gears.surface"] = { ["wibox.hierarchy"] = true },
}

4
lib/wibox/layout/align.lua
View File

@ -10,7 +10,7 @@ local table = table
local pairs = pairs
local type = type
local floor = math.floor
local util = require("awful.util")
local gtable = require("gears.table")
local base = require("wibox.widget.base")
local align = {}
@ -186,7 +186,7 @@ end
-- @property children
function align:get_children()
return util.from_sparse {self._private.first, self._private.second, self._private.third}
return gtable.from_sparse {self._private.first, self._private.second, self._private.third}
end
function align:set_children(children)