awesomewm-mirrors
/
awesome
mirror of https://github.com/awesomeWM/awesome.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove empty-argument checks 

This code removes code which could only be hit be running awesome --search '' or
awesome -c ''. In both cases there are many possibilities for weird/invalid
arguments and I don't see why the empty string deserves special treatment.

Note that awesome --search does NOT hit this code, because getopt_long handles
the case of "completely missing" arguments itself.

Signed-off-by: Uli Schlachter <psychon@znc.in>
This commit is contained in:
Uli Schlachter 2016-08-31 13:27:07 +02:00
parent fd90061c24
commit 4cbf87b441
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
awesome.c
View File

@ -507,16 +507,10 @@ main(int argc, char **argv)
run_test = true; run_test = true;
break; break;
case 'c': case 'c':
if(a_strlen(optarg)) confpath = a_strdup(optarg);
confpath = a_strdup(optarg);
else
fatal("-c option requires a file name");
break; break;
case 's': case 's':
if(a_strlen(optarg)) string_array_append(&searchpath, a_strdup(optarg));
string_array_append(&searchpath, a_strdup(optarg));
else
fatal("-s option requires a directory name");
break; break;
case 'a': case 'a':
no_argb = true; no_argb = true;