awesomewm-mirrors
/
awesome
mirror of https://github.com/awesomeWM/awesome.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

textclock: Detect failures from g_date_time_format (#2119) 

If g_date_time_format() fails, it returns a NULL pointer. This change
makes the textclock detect this and print a warning. This warning
contains 'g_date_time_format()' so that people can ask their favorite
search engine for the supported formats of this function. This warning
also contains the actual format string so that all the information is
available in one place and possible bug reports hopefully include the
format string.

Reference: https://github.com/awesomeWM/awesome/issues/2118
Signed-off-by: Uli Schlachter <psychon@znc.in>
This commit is contained in:
Uli Schlachter 2017-11-24 05:27:18 +01:00 committed by Emmanuel Lepage Vallée
parent b0220a3804
commit 5ef937c07c
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/wibox/widget/textclock.lua
View File

@ -44,7 +44,13 @@ function textclock.new(format, timeout, timezone)
local w = textbox()
w.force_update = textclock.force_update
function w._private.textclock_update_cb()
w:set_markup(DateTime.new_now(timezone):format(format))
local str = DateTime.new_now(timezone):format(format)
if str == nil then
require("gears.debug").print_warning("textclock: "
.. "g_date_time_format() failed for format "
.. "'" .. format .. "'")
end
w:set_markup(str)
w._timer.timeout = calc_timeout(timeout)
w._timer:again()
return true -- Continue the timer