awesomewm-mirrors
/
awesome
mirror of https://github.com/awesomeWM/awesome.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tag: Fix an off-by-one caused by a mutatation during a `foreach`. 

Fix #3167
This commit is contained in:
Emmanuel Lepage Vallee 2020-09-13 23:52:46 -07:00
parent 97c3849ae7
commit 68bc9eba15
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
objects/tag.c
View File

@ -473,8 +473,10 @@ luaA_tag_clients(lua_State *L)
if(lua_gettop(L) == 2) if(lua_gettop(L) == 2)
{ {
luaA_checktable(L, 2); luaA_checktable(L, 2);
foreach(c, tag->clients) for(int j = 0; j < clients->len; j++)
{ {
client_t *c = clients->tab[j];
/* Only untag if we aren't going to add this tag again */ /* Only untag if we aren't going to add this tag again */
bool found = false; bool found = false;
lua_pushnil(L); lua_pushnil(L);
@ -483,7 +485,7 @@ luaA_tag_clients(lua_State *L)
client_t *tc = luaA_checkudata(L, -1, &client_class); client_t *tc = luaA_checkudata(L, -1, &client_class);
/* Pop the value from lua_next */ /* Pop the value from lua_next */
lua_pop(L, 1); lua_pop(L, 1);
if (tc != *c) if (tc != c)
continue; continue;
/* Pop the key from lua_next */ /* Pop the key from lua_next */
@ -491,8 +493,10 @@ luaA_tag_clients(lua_State *L)
found = true; found = true;
break; break;
} }
if(!found) if(!found) {
untag_client(*c, tag); untag_client(c, tag);
j--;
}
} }
lua_pushnil(L); lua_pushnil(L);
while(lua_next(L, 2)) while(lua_next(L, 2))