From 74bb34ff0090f0fc125d7202bea6248955f2e027 Mon Sep 17 00:00:00 2001
From: Emmanuel Lepage Vallee <elv1313@gmail.com>
Date: Mon, 24 Apr 2017 03:10:03 -0400
Subject: [PATCH] wallpaper: Turn asserts into warning

Regression in v4.1. It causes the `rc.lua` (and the fallback) to
exit when the wallpaper is missing or something went wrong.

In <= 4.0, the wallpaper wasn't loaded, but Awesome didn't "crash".

There should be no asserts in the code called during the first
event loop iteration.
---
 lib/gears/wallpaper.lua | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/lib/gears/wallpaper.lua b/lib/gears/wallpaper.lua
index 2f2fbea6f..01f70f6cb 100644
--- a/lib/gears/wallpaper.lua
+++ b/lib/gears/wallpaper.lua
@@ -8,6 +8,7 @@ local cairo = require("lgi").cairo
 local color = require("gears.color")
 local surface = require("gears.surface")
 local timer = require("gears.timer")
+local debug = require("gears.debug")
 local root = root
 
 local wallpaper = { mt = {} }
@@ -139,7 +140,9 @@ function wallpaper.centered(surf, s, background, scale)
     if surf ~= original_surf then
         surf:finish()
     end
-    assert(cr.status == "SUCCESS", "Cairo context entered error state: " .. cr.status)
+    if cr.status ~= "SUCCESS" then
+        debug.print_warning("Cairo context entered error state: " .. cr.status)
+    end
 end
 
 --- Set a tiled wallpaper.
@@ -164,7 +167,9 @@ function wallpaper.tiled(surf, s, offset)
     if surf ~= original_surf then
         surf:finish()
     end
-    assert(cr.status == "SUCCESS", "Cairo context entered error state: " .. cr.status)
+    if cr.status ~= "SUCCESS" then
+        debug.print_warning("Cairo context entered error state: " .. cr.status)
+    end
 end
 
 --- Set a maximized wallpaper.
@@ -202,7 +207,9 @@ function wallpaper.maximized(surf, s, ignore_aspect, offset)
     if surf ~= original_surf then
         surf:finish()
     end
-    assert(cr.status == "SUCCESS", "Cairo context entered error state: " .. cr.status)
+    if cr.status ~= "SUCCESS" then
+        debug.print_warning("Cairo context entered error state: " .. cr.status)
+    end
 end
 
 --- Set a fitting wallpaper.
@@ -238,7 +245,9 @@ function wallpaper.fit(surf, s, background)
     if surf ~= original_surf then
         surf:finish()
     end
-    assert(cr.status == "SUCCESS", "Cairo context entered error state: " .. cr.status)
+    if cr.status ~= "SUCCESS" then
+        debug.print_warning("Cairo context entered error state: " .. cr.status)
+    end
 end
 
 return wallpaper