From 981acad29d96582eab69ddaf08cff22e2a3aaf41 Mon Sep 17 00:00:00 2001 From: Uli Schlachter Date: Mon, 24 Mar 2014 22:05:21 +0100 Subject: [PATCH] awful.tag: Don't tag clients before manage() (FS#1238) This commit partly reverts commit b4c83d0e702168c5bb. Because the C code emits property::screen before manage, this caused awful.tag.withcurrent() to run on a client before it really was being managed. This then tagged the client. Because of this tag changes, awful.layout reacted and ran the layout code. Because c.type wasn't set up at this point yet, the client wasn't considered to be floating yet. This caused the client's geometry to change and thus its floating geometry was messed up. Signed-off-by: Uli Schlachter --- lib/awful/tag.lua.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/awful/tag.lua.in b/lib/awful/tag.lua.in index ad89dfb68..2273d473d 100644 --- a/lib/awful/tag.lua.in +++ b/lib/awful/tag.lua.in @@ -567,10 +567,10 @@ capi.client.connect_signal("manage", function(c, startup) c.screen = capi.mouse.screen end end + c:connect_signal("property::screen", tag.withcurrent) end) capi.client.connect_signal("manage", tag.withcurrent) -capi.client.connect_signal("property::screen", tag.withcurrent) capi.tag.connect_signal("request::select", tag.viewonly) capi.tag.add_signal("property::hide")