doc: Add more property warnings.

The goal is to fix these issues so the new rendering can become
stable.
This commit is contained in:
Emmanuel Lepage Vallee 2022-07-12 21:59:19 -07:00
parent 19e586f969
commit a698d20e81
1 changed files with 38 additions and 4 deletions

View File

@ -224,6 +224,13 @@ create_type {
) )
end end
if type == "bool" then
print(
"WARNING: Property ".. item.name .." from "..item.module.name..
" type is `bool`, please use `boolean`."
)
end
-- One of the repeated problem we have is the first word of the -- One of the repeated problem we have is the first word of the
-- description being removed because it is used as the property name. -- description being removed because it is used as the property name.
-- This "rule" might be stupid, but it prevents it from accidentally -- This "rule" might be stupid, but it prevents it from accidentally
@ -235,10 +242,37 @@ create_type {
) )
end end
-- Properties should have a default value. If they don't or if the local def = item:default_of_param(item.params[1])
-- default depends on the context, then `opt=nil` should be used to
-- mute this warning. -- Check the default value for obvious mistakes.
if not item:default_of_param(item.params[1]) then if def then
-- Detect the blatant missing quote marks for string. This is important
-- to differentiate variables from string literals.
if type == "string" and def:sub(1,1) ~= '"' and not def:find(".") then
print(
"WARNING: Property ".. item.name .." from "..item.module.name..
" is a string, but the default value is not quoted."
)
end
-- If the default value is `nil`, then the property must be nullable.
if def == "nil" and not type:find("nil") then
print(
"WARNING: Property ".. item.name .." from "..item.module.name..
" default value is `nil`, but the type doesn't allow it"
)
end
if type == "boolean" and (not (def == "true" or def == "false")) and (not def:find(".")) then
print(
"WARNING: Property ".. item.name .." from "..item.module.name..
" is a boolean, but is neither `true`, `false` or an alias"
)
end
else
-- Properties should have a default value. If they don't or if the
-- default depends on the context, then `opt=nil` should be used to
-- mute this warning.
local auto_opt = nil local auto_opt = nil
-- Extract the default value from other metadata. -- Extract the default value from other metadata.