Merge pull request #2329 from Elv13/fix_minimize_activate

Fix 3rd party toolbar unminimization and the default rc.lua focusable issue

awesomerc.lua

@@ -155,16 +155,11 @@ local tasklist_buttons = gears.table.join(
                                               if c == client.focus then
                                                   c.minimized = true
                                               else
-                                                  -- Without this, the following
+                                                  c:emit_signal(
-                                                  -- :isvisible() makes no sense
+                                                      "request::activate",
-                                                  c.minimized = false
+                                                      "tasklist",
-                                                  if not c:isvisible() and c.first_tag then
+                                                      {raise = true}
-                                                      c.first_tag:view_only()
+                                                  )
-                                                  end
-                                                  -- This will also un-minimize
-                                                  -- the client, if needed
-                                                  client.focus = c
-                                                  c:raise()
                                               end
                                           end),
                      awful.button({ }, 3, client_menu_toggle_fn()),
@@ -335,8 +330,9 @@ globalkeys = gears.table.join(
                   local c = awful.client.restore()
                   -- Focus restored client
                   if c then
-                      client.focus = c
+                    c:emit_signal(
-                      c:raise()
+                        "request::activate", "key.unminimize", {raise = true}
+                    )
                   end
               end,
               {description = "restore minimized", group = "client"}),
@@ -459,17 +455,14 @@ end
 -- @DOC_CLIENT_BUTTONS@
 clientbuttons = gears.table.join(
     awful.button({ }, 1, function (c)
-        client.focus = c;
+        c:emit_signal("request::activate", "mouse_click", {raise = true})
-        c:raise()
     end),
     awful.button({ modkey }, 1, function (c)
-        client.focus = c
+        c:emit_signal("request::activate", "mouse_click", {raise = true})
-        c:raise()
         awful.mouse.client.move(c)
     end),
     awful.button({ modkey }, 3, function (c)
-        client.focus = c
+        c:emit_signal("request::activate", "mouse_click", {raise = true})
-        c:raise()
         awful.mouse.client.resize(c)
     end)
 )
@@ -559,13 +552,11 @@ client.connect_signal("request::titlebars", function(c)
     -- buttons for the titlebar
     local buttons = gears.table.join(
         awful.button({ }, 1, function()
-            client.focus = c
+            c:emit_signal("request::activate", "titlebar", {raise = true})
-            c:raise()
             awful.mouse.client.move(c)
         end),
         awful.button({ }, 3, function()
-            client.focus = c
+            c:emit_signal("request::activate", "titlebar", {raise = true})
-            c:raise()
             awful.mouse.client.resize(c)
         end)
     )
@@ -598,10 +589,7 @@ end)
 
 -- Enable sloppy focus, so that focus follows mouse.
 client.connect_signal("mouse::enter", function(c)
-    if awful.layout.get(c.screen) ~= awful.layout.suit.magnifier
+    c:emit_signal("request::activate", "mouse_enter", {raise = true})
-        and awful.client.focus.filter(c) then
-        client.focus = c
-    end
 end)
 
 -- @DOC_BORDER@

lib/awful/ewmh.lua

@@ -15,6 +15,7 @@ local aclient = require("awful.client")
 local aplace = require("awful.placement")
 local asuit = require("awful.layout.suit")
 local beautiful = require("beautiful")
+local alayout = require("awful.layout")
 
 local ewmh = {
     generic_activate_filters    = {},
@@ -85,7 +86,13 @@ end
 function ewmh.activate(c, context, hints) -- luacheck: no unused args
     hints = hints or  {}
 
-    if c.focusable == false and not hints.force then return end
+    if c.focusable == false and not hints.force then
+        if hints.raise then
+            c:raise()
+        end
+
+        return
+    end
 
     local found, ret = false
 
@@ -102,6 +109,12 @@ function ewmh.activate(c, context, hints) -- luacheck: no unused args
         if found then break end
     end
 
+    -- Minimized clients can be requested to have focus by, for example, 3rd
+    -- party toolbars and they might not try to unminimize it first.
+    if ret ~= false and hints.raise then
+        c.minimized = false
+    end
+
     if ret ~= false and c:isvisible() then
         client.focus = c
     elseif ret == false and not hints.force then
@@ -393,6 +406,15 @@ function ewmh.client_geometry_requests(c, context, hints)
     end
 end
 
+-- The magnifier layout doesn't work with focus follow mouse.
+ewmh.add_activate_filter(function(c)
+    if alayout.get(c.screen) ~= alayout.suit.magnifier
+      and aclient.focus.filter(c) then
+        return nil
+    else
+        return false
+    end
+end, "mouse_enter")
 
 client.connect_signal("request::activate", ewmh.activate)
 client.connect_signal("request::tag", ewmh.tag)