From d9f27bdf4befbce310dc06325ea7450ea539cfff Mon Sep 17 00:00:00 2001 From: Emmanuel Lepage Vallee Date: Mon, 5 Jul 2021 01:29:07 -0700 Subject: [PATCH] placement: Do not leak the composed placement "override" in the args. Without this change, if a composed placement was used, it would leak the "override_geometry" in the args, which would be kept cached during the next composed node. If that node had no override of its own, it would use the previous one by accident. In practice, it means it was impossible to resize a `wibar` manually. The `wibar` would always restore itself to the height (or width, for vertical ones) it previously had. --- lib/awful/placement.lua | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/awful/placement.lua b/lib/awful/placement.lua index c7599e8ae..32ebd8463 100644 --- a/lib/awful/placement.lua +++ b/lib/awful/placement.lua @@ -184,6 +184,10 @@ local function compose(...) attach(d, ret, args) end + -- Cleanup the override because otherwise it might leak into + -- future calls. + rawset(args, "override_geometry", nil) + return last_geo, rets end, "compose")