avoid using seq in awsetbg, and test for columns count argument of -m option.

Signed-off-by: Uli Schlachter <psychon@znc.in>
2010-10-11 17:00:11 +02:00 · 2010-10-11 17:00:11 +02:00 · f38566bd97
parent 0116d739b5
commit f38566bd97
1 changed files with 15 additions and 8 deletions
--- a/utils/awsetbg
+++ b/utils/awsetbg
@ -218,14 +218,21 @@ while [ $# -gt 0 ]; do
            montage=`which montage`
            if test ! -z "$montage"; then
                shift
+                if [ $# -eq 0 ]; then
+                    echo "-m option need a columns argument"
+                    exit # no more args
+                else
                    cols="$1"; shift
                    fns=""
-                for i in `seq $cols`; do
-                    fns="$fns $1";
-                done;
+                    i=$cols
+                    while [ $i -gt 0 ]; do
+                        fns="$fns $1"
+                        i=$(($i - 1))
+                    done
                    shift
                    $montage $fns -geometry +0+0 -tile ${cols}x $CONFIG_DIR/montage.png
                    wallpaper=$CONFIG_DIR/montage.png
+                fi
            else
                shift
                echo "montage not found. Falling back to single image"