test(menubar): enable the test back on lua 5.3

and disable it back but only for specific lgi version
This commit is contained in:
actionless 2021-05-27 04:24:52 +02:00
parent 2249dc3c81
commit fa7648e6d6
1 changed files with 3 additions and 7 deletions

View File

@ -10,14 +10,10 @@ function menubar.refresh(...)
orig_refresh(...) orig_refresh(...)
end end
-- XXX We are building Lua 5.3 with -DLUA_USE_APICHECK=1 and this catches some -- XXX This test sporadically errors on LuaJIT ("attempt to call a number
-- bugs in lgi. Thus, do not run this test with Lua 5.3 until lgi is fixed.
-- We run into the same bug when doing code-coverage analysis, supposedly
-- because the additional GC activity means that something which is GC-able when
-- it should not gets collected too early.
-- This test also sporadically errors on LuaJIT ("attempt to call a number
-- value"). This might be a different issue, but still, disable the test. -- value"). This might be a different issue, but still, disable the test.
if _VERSION == "Lua 5.3" or debug.gethook() or jit then --luacheck: globals jit -- And also breaks other tests due to weirdness of older lgi version.
if os.getenv('LGIVER') == '0.8.0' or jit then --luacheck: globals jit
print("Skipping this test since it would just fail.") print("Skipping this test since it would just fail.")
runner.run_steps { function() return true end } runner.run_steps { function() return true end }
return return