awesome

Commit Graph

Author	SHA1	Message	Date
Uli Schlachter	3bda88ff64	Remove obsolete entries from check_for_invalid_requires.lua (#1673 ) Most of the entries that are marked as "TODO: Get rid of these" were handled. wibox.layout.align:get_children() never worked (it always called a non-existent function), so we can easily fix this entry without introducing a regression. I opened https://github.com/awesomeWM/awesome/issues/1672 to track the underlying problem behind the broken :get_children() function (which is missing test coverage). Signed-off-by: Uli Schlachter <psychon@znc.in>	2017-03-26 15:20:18 -04:00
Uli Schlachter	0afed66ccf	Add a utility checking uses of require()s Currently, "everything can require everything". It's an unstructured mess which sometimes causes problems. This commit adds a tool that enforces a white-list of require() uses. It uses depgraph to scan the source code and then each use of require() that is found is checked. If any violations are found, the tool returns a failure. This tool is wired up to a new target "make check-requires" which is included in "make check". Thus, Travis will run this. Reference: https://github.com/awesomeWM/awesome/issues/1400 Signed-off-by: Uli Schlachter <psychon@znc.in>	2017-02-08 08:35:43 +01:00

Author

SHA1

Message

Date

Uli Schlachter

3bda88ff64

Remove obsolete entries from check_for_invalid_requires.lua (#1673 )

Most of the entries that are marked as "TODO: Get rid of these" were
handled. wibox.layout.align:get_children() never worked (it always
called a non-existent function), so we can easily fix this entry without
introducing a regression.

I opened https://github.com/awesomeWM/awesome/issues/1672 to track the
underlying problem behind the broken :get_children() function (which is
missing test coverage).

Signed-off-by: Uli Schlachter <psychon@znc.in>

2017-03-26 15:20:18 -04:00

Uli Schlachter

0afed66ccf

Add a utility checking uses of require()s

Currently, "everything can require everything". It's an unstructured
mess which sometimes causes problems.

This commit adds a tool that enforces a white-list of require() uses. It
uses depgraph to scan the source code and then each use of require()
that is found is checked. If any violations are found, the tool returns
a failure.

This tool is wired up to a new target "make check-requires" which is
included in "make check". Thus, Travis will run this.

Reference: https://github.com/awesomeWM/awesome/issues/1400
Signed-off-by: Uli Schlachter <psychon@znc.in>

2017-02-08 08:35:43 +01:00

2 Commits