Commit Graph

10891 Commits

Author SHA1 Message Date
Emmanuel Lepage Vallee bd8f2f936b naughty: Fix a memory leak related to suspended notifications. 2021-09-22 19:17:02 -07:00
Emmanuel Lepage Vallee 552b2a22d1 tests: Test the notification presets.
Make sure they behave the same in legacy and ruled modes.
2021-09-22 19:17:02 -07:00
Emmanuel Lepage Vallee 9336b62f80 ruled.notification: Handle legacy presets.
This is deprecated, but some modules like `lain` use them, so it
must still minimally work for backward compatibility.
2021-09-22 19:17:02 -07:00
Emmanuel Lepage Vallee e752943b98 notification: Correctly handle `screen` set in the presets.
It was setting directly to `_private`, which both didn't work
and caused a memory leak.

Fix #3428
2021-09-22 19:17:02 -07:00
Emmanuel Lepage Vallee 21a111d154 naughty: Allow to set the message from the presets again.
This was never really supported and is really not what the presets
were event meant to be used for. But it worked and `lain` used it.
2021-09-22 19:17:02 -07:00
Emmanuel Lepage Vallee 89c84caee4 naughty.legacy: Explicitly remove the screen.
Do not rely on the GC. It isn't reliable with Luajit.
2021-09-22 13:39:58 -07:00
poisson-aerohead 87e09f81ab
Correction of error message in awful.keygrabber.run_with_keybindings (#3445)
Two calls to gdebug.print_warning() in run_with_keybindings use an
argument that concatenates a fixed string with the result returned by a
call to gdebug.dump(). gdebug.dump() is the debug library function for
immediate printing. It has no return value. This causes the correct
message in print_warning to not be printed, and also causes a
naughty.notify box to appear warning of an attempt to concatenate to an
empty variable.

The call to gdebug.print_warning should have an argument made by
concatenating to gdebug.dump_return(). Incidentally, this is in fact the
function used internally by gdebug.print().

Signed off by: Brian Sobulefsky <brian.sobulefsky@protonmail.com>
2021-09-21 08:34:46 -07:00
Emmanuel Lepage Vallée 5ca16ae8a0
Merge pull request #3364 from Aire-One/fix/awful.key-constructor
[doc] awful.key contructor and general improvements
2021-09-20 11:39:41 -07:00
martin f. krafft abac464384
Replace /usr/bin/which with command -v (#3439)
The `which` utility is being phased out since POSIX has mandated
`command -v` for the same task, so let's use that in the awesome-client
script.

Signed-off-by: martin f. krafft <madduck@madduck.net>
2021-09-20 10:21:43 -07:00
Emmanuel Lepage Vallée d9bfc9c37e
Merge pull request #3442 from sclu1034/feature/github_actions
Fix "test previous commit" workflow task with only one commit
2021-09-19 22:17:11 -07:00
Emmanuel Lepage Vallée c3a508a886
Merge pull request #3386 from Elv13/awful_wibar
Fix some wibar bugs, polish the API a bit and add some doc.
2021-09-19 13:05:11 -07:00
Lucas Schwiderski 4b6d7fd241
bug(github_actions): Fix logging failed commits
Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
2021-09-19 15:11:26 +02:00
Lucas Schwiderski c12715e11f
bug(github_actions): Skip testing single previous commit
Due to the default of executing bash with `-e -o pipefail` this didn't
fail gracefully anymore. But an explicit check makes more sense anyways.
2021-09-19 15:02:46 +02:00
Emmanuel Lepage Vallée edf21742b8
Merge pull request #3438 from Elv13/fix_3384
Fix 3384
2021-09-17 13:10:58 -07:00
Emmanuel Lepage Vallee e27b908ca0 doc: Document the naughty.action "invoked" signal. 2021-09-16 17:25:46 -07:00
Emmanuel Lepage Vallee 17bd5fb036 naughty: Pass the notification object to the action "invoked" signal.
Fix #3384
2021-09-16 17:22:33 -07:00
Emmanuel Lepage Vallée 73e908ed95 Apply suggestions from code review
Co-authored-by: Lucas Schwiderski <4508454+sclu1034@users.noreply.github.com>
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallée 6ad693eff0 Apply suggestions from code review
Co-authored-by: Aire-One <Aire-One@users.noreply.github.com>
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee d5d74e44de doc: Document the wibar module. 2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee b2368c54a8 tests: Fix the `screen` template rendering with multiple screens.
It only worked for a single screen. It still isn't perfect, but
much better than it was.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee dd6163ffe6 shims: Fix the screen workarea value.
It didn't work with multiple screens.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee a94a4beb6f doc: Add a missing DOC_HIDE which damaged the rendering. 2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee b883855272 wibar: Allow to configure how conflicts between wibars are resolved.
Previously, the horizontal wibars would always get priority. Now,
this can be configured.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee 529a6c2a8d wibar: Expose update_workarea.
It is now possible to create wibars which are not changing the
tiled area.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee 0828c20a55 rc.lua: Be consistent about how the wibar is created.
The syntax was a leftover from ancient time where the wibar
constructor could not forward the properties to the wibox and
when the wibox didn't take a `widget` argument.

I make this change mostly to be consistent with the documentation
examples.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee 67dc363437 wibar: Modernize the module structure.
Move the burdensome legacy code into local function so the normal
`gears.table.crush` module setup can be used. This fixes a couple
monior issues where `args` would be ignored.

This also makes a minor change to the logic. Changing the position
always moves to wibar to the end of the stack. Previously, there
was a minor case where it would not. There was also the case when
setting the same position twice would move the wibar, which was a bug.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee dab767af3e wibar: Restore the ability to align a wibar.
This was lost in 3.5->4.0 update, but still had some references in
the code and doc. At the time, the plan was to add it back
"shortly after" based on the `awful.placement` code, but it was
never merged.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee b62f343409 wibar: Add margins.
This is a feature request from Reddit. With this commit, the
awful.placement margins are exposed to the wibar API.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee ab977b2358 placement: Fix the struts size when margins are present.
Previously, it only added 1 of the 2 sides of the relevant margins
to the struct size. For example, if the position was "top", then
only the top margin was added, not the bottom one.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee b4afd0206b tests: Make sure wibar resize works.
Also add some garbage collection tests. This was my original
theory about why resizing was broken, but it turned out something
in `awful.placement` leaked, not the wibar references.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee d9f27bdf4b placement: Do not leak the composed placement "override" in the args.
Without this change, if a composed placement was used, it would leak
the "override_geometry" in the args, which would be kept cached during
the next composed node. If that node had no override of its own, it
would use the previous one by accident.

In practice, it means it was impossible to resize a `wibar` manually.
The `wibar` would always restore itself to the height (or width, for
vertical ones) it previously had.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallee 4b606fb3d7 notification: Fix rendering during early screen creation.
If the problem happens early enough, it was possible that the
screen arrway wasn't initialized yet. In that case, the notification
would fail to render.
2021-09-12 01:59:48 -07:00
Emmanuel Lepage Vallée 2a8c17daea
Merge pull request #3434 from sclu1034/test/github_actions
Fix GitHub Actions
2021-09-11 14:47:10 -07:00
Lucas Schwiderski f39e8d261b
Fall back to GitHub's token for coveralls
Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
2021-09-11 14:03:11 +02:00
Lucas Schwiderski 86ec4888b3
Fix newline printing
Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
2021-09-11 13:49:47 +02:00
Lucas Schwiderski cc882585de
Fix test for previous commits
Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
2021-09-11 13:47:48 +02:00
Emmanuel Lepage Vallée ee3c42652e
Merge pull request #3292 from sclu1034/feature/github_actions
Migrate CI to GitHub Actions
2021-09-10 14:25:54 -07:00
mergify[bot] 7ae6d26363
Merge pull request #3387 from mattplm/master
Stop using fixed row number in calendars
2021-09-07 23:51:38 +00:00
mergify[bot] c88dcf5405
Merge pull request #3409 from vicious-widgets/vicious-async
Remove Vicious as async counterexample
2021-09-07 21:25:04 +00:00
mattplm 97726e8f38 Stop using fixed row number 2021-08-28 23:10:40 +02:00
ViSaturn 13cd20780e
spelling & grammar issues (#3410)
replace request to requsts & replace futur to future
2021-08-14 23:38:01 -07:00
Nguyễn Gia Phong be45b40cdb
Remove Vicious as async counterexample
Vicious has stopped using io.popen since October 2019.
2021-08-12 21:12:33 +07:00
aflorea-2k 8a81745d4d
doc(index.html): fixed broken links (#3402)
Fixes #3393, where links to guides were hard-coded, and pointed to wrong
places in the git version.
2021-08-04 11:07:57 -07:00
aflorea-2k 260f6dbe97
doc(wibox.widget.textbox.html): fixed pango links (#3401)
Links to gnome's pango webpage
(https://developer.gnome.org/pango/stable/PangoMarkupFormat.html) were
broken. They now all point to docs.gtk.org .
2021-08-03 20:02:25 +02:00
Emmanuel Lepage Vallée 4b494952da
Merge pull request #3400 from aflorea-2k/06-appearance.md_duplicates-fix
06 appearance.md duplicates fix (fixes #3328)
2021-08-02 18:13:35 -07:00
mergify[bot] fcd5918bd9
Merge pull request #3399 from sclu1034/feature/docs
Various doc improvements nr. 4
2021-08-03 01:12:11 +00:00
aflorea-2k ddb88ed945
List of values in table renders as HTML list
Co-authored-by: Aire-One <Aire-One@users.noreply.github.com>
2021-08-02 14:48:50 +02:00
Andrei Florea 5f5b1dcb2b
Removed dupicate computation of values 2021-08-02 14:46:20 +02:00
Andrei Florea b73b885c1e
06-appearance.md no longer mentions duplicates. (fixes #3328)
The table entries that were duplicated are now side by side.
There are no longer duplicates in the sample file.
2021-07-31 17:29:56 +02:00
Lucas Schwiderski 0a68341c12
doc(w.c.radialprogressbar): Show example code
Adds the code snippet for the example shown in the module description.

Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
2021-07-31 15:05:10 +02:00