Go to file
Uli Schlachter 56e727e026 Fix a race with setting the focus
There are two ways in which the input focus can change: Lua can request
a change and the X11 server can inform us that the input focus changed
(because some application changed it).

In the first case, we still have to inform the X11 server about the
desired change, in the second case we must not to avoid races due to
X11's asynchronous nature.

However, there was a case where we screwed up: When a focus change is
still pending, meaning that Lua assigned the focus elsewhere, but we
have not yet sent this focus change to the X11 server, we could get an
event from the X11 server telling us that the focus changed. To make
sure that the pending focus change is not lost, we sent the focus change
out in this case (call to client_focus_refresh() in
event_handle_focusin()). After sending out this pending call, we updated
the internal state to record that whatever the X11 server just told us
had the focus. The intention was that our just sent-out focus change
will cause the X11 server to send a new event and our to-be-focused
client then has the focus.

However, if the pending focus change was for a client which only showed
up in this event loop iteration, the client was still banned. This means
that client_focus_refresh() would call client_unban() to be able to give
the focus to this client. However, since awesome (partly) allows to
"focus" currently banned clients, client_unban() recorded that there is
a pending focus change. This caused confusion later on.

In this specific bug, a main window opened a dialog, and when this
dialog was closed, a new dialog window was opened immediately. When the
first dialog was closed, Lua (the focus history) gave the input focus to
the main window. Now, a new dialog showed up and Lua focused it. Next,
we received the event from the X11 server telling us that the main
window was focused. Because there was still a pending focus change to
the new dialog window, event_handle_focusin() called
client_focus_refresh() to send out this focus change. This set
globalconf.focus.need_update to false and continued. However, because
the new dialog only just now appeared, it was still banned, meaning that
client_focus_refresh() had to call client_unban(). This set
globalconf.focus.need_update to true. Thus, when client_focus_refresh()
returned, globalconf.focus.need_update was incorrectly true. Next,
event_handle_focusin() recorded that the main window had the focus.
Thus, it now appeared as if there was a pending focus change for the
main window. Next, we got the event from the X11 server telling us that
the dialog is now focused, and because focus.need_update was set,
awesome now send out a focus change request for the main window.

Fix this race by unsetting globalconf.focus.need_update at the end of
client_focus_refresh() and not at the beginning, thus making sure that
client_unban() cannot set this flag again.

Fixes: https://github.com/awesomeWM/awesome/issues/2220
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-08-16 18:03:22 +02:00
build-utils gears.surface: Use GdkPixbuf 2018-01-18 18:19:07 +01:00
common Reduce code duplication with luaA_*_call_handler (#2321) 2018-07-25 18:31:02 -04:00
docs doc: Remove capi.keygrabber from the official doc 2018-08-06 19:03:25 -04:00
icons icons: remove invaders 2009-09-08 13:29:25 +02:00
lib Merge branch 'moue-typo' of https://github.com/psychon/awesome 2018-08-15 13:18:38 +02:00
manpages Merge branch 'more-manpage-updates' of https://github.com/psychon/awesome 2018-02-10 20:10:05 +01:00
objects Fix a race with setting the focus 2018-08-16 18:03:22 +02:00
spec tests: Mock capi.keygrabger 2018-07-29 10:45:40 -04:00
tests Merge branch 'example_tests_during_build_again' of https://github.com/psychon/awesome 2018-08-08 15:53:32 +02:00
themes feat(themes; beautiful): add partial support for GTK+3 themes (#2129) 2018-06-26 10:43:20 -04:00
utils Add examples and help text for awesome-client (#2162) 2018-01-21 17:40:38 -05:00
.busted tests: busted: add config file, use --verbose by default (#2076) 2017-10-22 18:05:00 +02:00
.editorconfig Add an EditorConfig file 2015-12-12 17:48:42 +01:00
.gitignore luacheck: enable cache (#2004) 2017-08-20 22:50:30 +02:00
.luacheckrc luacheck: enable cache (#2004) 2017-08-20 22:50:30 +02:00
.luacov luacov: include everything 2017-01-08 20:34:13 +01:00
.mergify.yml Mergify: do not use strict mode (#2319) 2018-07-25 00:38:13 +02:00
.travis.yml tests/examples: Run example-tests in build phase, not configure phase 2018-08-06 16:50:46 +02:00
CMakeLists.txt build: man pages: use asciidoctor instead of asciidoc (#2234) 2018-04-04 11:28:50 +02:00
ISSUE_TEMPLATE.md Add an ISSUE_TEMPLATE.md file (#997) 2016-07-09 19:18:02 +02:00
LICENSE chance license to GPLv2 2007-09-12 14:29:51 +02:00
Makefile Makefile: distclean: do not try to rm `awesome` (#2077) 2017-10-23 22:25:18 +02:00
Packaging.cmake Packaging.cmake: cache CPACK_GENERATOR (#1924) 2017-07-21 01:06:59 +02:00
README.md Add README.md symlink 2015-02-28 23:14:13 +01:00
awesome-version-internal.h Add a vim modeline to all C source 2015-12-12 17:42:16 +01:00
awesome.c Check for xdgInitHandle() failures (#2146) 2018-01-12 21:33:25 -05:00
awesome.desktop Remove deprecated Encoding key from awesome.desktop (#1394) 2017-01-13 22:21:50 +01:00
awesome.h remove encoding=utf-8 from modelines 2011-09-11 17:34:09 +02:00
awesomeConfig.cmake CMake: Use check_symbol_exists instead of check_function_exists 2018-07-26 09:12:40 +02:00
awesomerc.lua rc.lua: Use request::activate instead of client.focus. 2018-07-29 18:22:48 -04:00
banning.c Fix recursive enterleave ignore (#1747) 2017-04-21 18:53:25 +02:00
banning.h Clean up header includes 2014-03-30 20:07:48 +02:00
color.c Merge pull request #2207 from psychon/alpha_borders 2018-04-22 02:02:10 -04:00
color.h Correctly convert colors with alpha to a Lua string 2018-03-03 10:57:48 +01:00
config.h Merge branch 'find-fallback-config' of https://github.com/psychon/awesome 2017-01-27 17:39:30 +01:00
dbus.c Use signal_array_getbyname() where appropriate 2018-01-24 09:13:35 +01:00
dbus.h remove encoding=utf-8 from modelines 2011-09-11 17:34:09 +02:00
draw.c Add awesome.pixbuf_to_surface 2018-01-18 18:10:35 +01:00
draw.h Add awesome.pixbuf_to_surface 2018-01-18 18:10:35 +01:00
event.c 'Fix' codacy complaining about unused value 2017-11-17 10:31:50 +01:00
event.h Asynchronously update the keyboard state 2017-03-28 15:21:01 +02:00
ewmh.c client: Add request::geometry for client maximization 2017-05-23 22:33:26 +02:00
ewmh.h C code: save all instead of just one client icons 2017-03-07 22:45:49 +01:00
globalconf.h Asynchronously update the keyboard state 2017-03-28 15:21:01 +02:00
keygrabber.c keygrabber: Refactor to be an object instead of a function. 2018-08-06 19:03:25 -04:00
keygrabber.h Clean up header includes 2014-03-30 20:07:48 +02:00
luaa.c awesome.kill: allow negative PIDs (and 0) to support process groups 2018-07-04 14:55:51 +02:00
luaa.h luaA_warn: Balance stack (#2106) 2017-11-08 18:47:37 +01:00
mouse.c Reduce code duplication with luaA_*_call_handler (#2321) 2018-07-25 18:31:02 -04:00
mouse.h Revert "Support more than 5 mouse buttons" (FS#1082) 2013-03-29 16:07:13 +01:00
mousegrabber.c Remove @release @AWESOME_VERSION@ everywhere (#1157) 2016-10-09 22:36:20 +02:00
mousegrabber.h Revert "Support more than 5 mouse buttons" (FS#1082) 2013-03-29 16:07:13 +01:00
property.c Add signal property::size_hints to clients (#1768) 2017-05-13 23:25:48 +02:00
property.h Clean up header includes 2014-03-30 20:07:48 +02:00
root.c doc: Add fake_inputs examples. 2018-08-06 19:03:25 -04:00
selection.c Remove @release @AWESOME_VERSION@ everywhere (#1157) 2016-10-09 22:36:20 +02:00
selection.h remove encoding=utf-8 from modelines 2011-09-11 17:34:09 +02:00
spawn.c Use signal_array_getbyname() where appropriate 2018-01-24 09:13:35 +01:00
spawn.h Use command line instead of env for passing children 2017-06-04 16:04:44 +02:00
stack.c doc: fix warnings from doxygen 2015-02-14 20:17:13 +01:00
stack.h Clean up header includes 2014-03-30 20:07:48 +02:00
strut.c geometry: Use the relevant rounding functions instead of integers 2016-04-18 04:20:22 -04:00
strut.h remove encoding=utf-8 from modelines 2011-09-11 17:34:09 +02:00
systray.c Make alpha work on window borders 2018-03-03 10:57:48 +01:00
systray.h Remove unused argument to systray_request_handle() 2016-05-29 14:33:23 +02:00
xkb.c Asynchronously update the keyboard state 2017-03-28 15:21:01 +02:00
xkb.h Asynchronously update the keyboard state 2017-03-28 15:21:01 +02:00
xrdb.c Don't print warnings for non-existing xrdb values 2017-05-24 10:06:24 +02:00
xrdb.h Add a vim modeline to all C source 2015-12-12 17:42:16 +01:00
xwindow.c Add & use a non-fatal kind of assert() (#1779) 2017-05-13 23:22:15 +02:00
xwindow.h Set WM_CLASS and WM_NAME on all our windows (#551) 2015-11-19 22:23:25 +01:00

README.md

Readme

About Awesome

Awesome is a highly configurable, next generation framework window manager for X.

Building and installation

After extracting the dist tarball, run:

make

This will create a build directory, run cmake in it and build Awesome.

After building is finished, you can either install via make install:

make install  # you might need root permissions

or by auto-generating a .deb or .rpm package, for easy removal later on:

make package

sudo dpkg -i awesome-x.y.z.deb
# or
sudo rpm -Uvh awesome-x.y.z.rpm

NOTE: Awesome uses cmake to build. In case you want to pass arguments to cmake, please use the CMAKE_ARGS environment variable. For instance:

CMAKE_ARGS="-DCMAKE_INSTALL_PREFIX=/opt/awesome" make

Build dependencies

Awesome has the following dependencies (besides a more-or-less standard POSIX environment):

Additionally, the following optional dependencies exist:

  • DBus for DBus integration and the awesome-client utility
  • asciidoctor for generating man pages
  • gzip for compressing man pages
  • ldoc >= 1.4.5 for generating the documentation
  • busted for running unit tests
  • luacheck for static code analysis
  • LuaCov for collecting code coverage information
  • libexecinfo on systems where libc does not provide backtrace_symbols() to generate slightly better backtraces on crashes
  • Xephyr or Xvfb for running integration tests
  • GTK+ >= 3.10 for ./themes/gtk/

Running Awesome

You can directly select Awesome from your display manager. If not, you can add the following line to your .xinitrc to start Awesome using startx or to .xsession to start Awesome using your display manager:

exec awesome

In order to connect Awesome to a specific display, make sure that the DISPLAY environment variable is set correctly, e.g.:

DISPLAY=foo.bar:1 exec awesome

(This will start Awesome on display :1 of the host foo.bar.)

Configuration

The configuration of Awesome is done by creating a $XDG_CONFIG_HOME/awesome/rc.lua file, typically ~/.config/awesome/rc.lua.

An example configuration named awesomerc.lua is provided in the source.

Troubleshooting

On most systems any message printed by Awesome (including warnings and errors) is written to ~/.xsession-errors.

If Awesome does not start or the configuration file is not producing the desired results the user should examine this file to gain insight into the problem.

Debugging tips

You can call awesome with gdb like this:

DISPLAY=:2 gdb awesome

Then in gdb set any args and run it:

(gdb) set arg --replace
(gdb) run

Reporting issues

Please report any issues you may find on our bugtracker. You can submit pull requests on the github repository. Please read the contributing guide for any coding, documentation or patch guidelines.

Status

Build Status

Documentation

Online documentation is available at https://awesomewm.org/apidoc/.

License

The project is licensed under GNU General Publice License v2 or later. You can read it online at (v2 or v3).