ccaa75f4b4
A call to cairo_close_path() adds a straight line to the beginning of the current sub-path. This is used in some of the shapes to, well, close the shapes. Sub-paths can be created explicitly via cairo_new_sub_path(), but also implicitly via cairo_move_to(). When a new sub-path is started, there is no current point on the path. This means that e.g. cairo_line_to() is in this start equivalent to cairo_move_to() (= no line is created) and that cairo_curve_to() first does a cairo_move_to() to the beginning of the curve. Similarly, cairo_arc() and cairo_arc_negative() first do a line_to() to the beginning of the arc, and this line_to() can be implicitly turned into a curve_to(). The problem with the code in gears.shape is that parts of the code (implicitly) assume that there is not yet any path when the shape function is called. If this assumption is broken, the call to close_path() could go to the wrong point, because the path did not start at the expected position. Most of the functions in gears.shape already implicitly start a new sub-path via a call to cairo_move_to(). Those that do not (necessarily) begin with a call to cairo_move_to() are handled in this commit: They get an explicit call to cairo_new_sub_path(). This change fixes the issue reported at https://github.com/awesomeWM/awesome/pull/2804, because the shapes will no longer be influenced by the pre-existing path. The move_to() that was left around and caused that issue turns into a degenerate part (it only has a move_to(), so nothing can be drawn) and is then discarded by cairo. Signed-off-by: Uli Schlachter <psychon@znc.in> |
||
---|---|---|
build-utils | ||
common | ||
docs | ||
icons | ||
lib | ||
manpages | ||
objects | ||
spec | ||
tests | ||
themes | ||
utils | ||
.busted | ||
.editorconfig | ||
.gitignore | ||
.luacheckrc | ||
.luacov | ||
.mergify.yml | ||
.travis.yml | ||
AutoOption.cmake | ||
CMakeLists.txt | ||
ISSUE_TEMPLATE.md | ||
LICENSE | ||
Makefile | ||
Packaging.cmake | ||
README.md | ||
awesome-version-internal.h | ||
awesome.c | ||
awesome.desktop | ||
awesome.h | ||
awesomeConfig.cmake | ||
awesomerc.lua | ||
banning.c | ||
banning.h | ||
color.c | ||
color.h | ||
config.h | ||
dbus.c | ||
dbus.h | ||
draw.c | ||
draw.h | ||
event.c | ||
event.h | ||
ewmh.c | ||
ewmh.h | ||
globalconf.h | ||
keygrabber.c | ||
keygrabber.h | ||
luaa.c | ||
luaa.h | ||
mouse.c | ||
mouse.h | ||
mousegrabber.c | ||
mousegrabber.h | ||
property.c | ||
property.h | ||
root.c | ||
selection.c | ||
selection.h | ||
spawn.c | ||
spawn.h | ||
stack.c | ||
stack.h | ||
strut.c | ||
strut.h | ||
systray.c | ||
systray.h | ||
xkb.c | ||
xkb.h | ||
xrdb.c | ||
xrdb.h | ||
xwindow.c | ||
xwindow.h |
README.md
Readme
About Awesome
Awesome is a highly configurable, next generation framework window manager for X.
Building and installation
After extracting the dist tarball, run:
make
This will create a build directory, run cmake
in it and build Awesome.
After building is finished, you can either install via make install
:
make install # you might need root permissions
or by auto-generating a .deb or .rpm package, for easy removal later on:
make package
sudo dpkg -i awesome-x.y.z.deb
# or
sudo rpm -Uvh awesome-x.y.z.rpm
NOTE: Awesome uses cmake
to build. In case you want to
pass arguments to cmake
, please use the CMAKE_ARGS
environment variable. For
instance:
CMAKE_ARGS="-DCMAKE_INSTALL_PREFIX=/opt/awesome" make
Installing current git master as a package receipts
Arch Linux AUR
sudo pacman -S --needed base-devel git
git clone https://aur.archlinux.org/awesome-git.git
cd awesome-git
makepkg -fsri
Debian-based
sudo apt build-dep awesome
git clone https://github.com/awesomewm/awesome
cd awesome
make package
sudo apt install *.deb
Build dependencies
Awesome has the following dependencies (besides a more-or-less standard POSIX environment):
- CMake >= 3.0.0
- Lua >= 5.1.0 or LuaJIT
- LGI >= 0.8.0
- xproto >= 7.0.15
- libxcb >= 1.6 with support for the RandR, XTest, Xinerama, SHAPE and XKB extensions
- libxcb-cursor
- libxcb-util >= 0.3.8
- libxcb-keysyms >= 0.3.4
- libxcb-icccm >= 0.3.8
- libxcb-xfixes
- xcb-util-xrm >= 1.0
- libxkbcommon with X11 support enabled
- libstartup-notification >= 0.10
- cairo with support for XCB and GObject introspection
- Pango with support for Cairo and GObject introspection
- GLib >= 2.40 with support for GObject introspection
- GIO with support for GObject introspection
- GdkPixbuf
- libX11 with xcb support
- Imagemagick's convert utility
- libxdg-basedir >= 1.0.0
Additionally, the following optional dependencies exist:
- DBus for DBus integration
and the
awesome-client
utility - asciidoctor for generating man pages
- gzip for compressing man pages
- ldoc >= 1.4.5 for generating the documentation
- busted for running unit tests
- luacheck for static code analysis
- LuaCov for collecting code coverage information
- libexecinfo on systems where libc does not provide
backtrace_symbols()
to generate slightly better backtraces on crashes Xephyr
orXvfb
for running integration tests- GTK+ >= 3.10 for
./themes/gtk/
- xcb-errors for pretty-printing of X11 errors
Running Awesome
You can directly select Awesome from your display manager. If not, you can
add the following line to your .xinitrc
to start Awesome using startx
or to .xsession
to start Awesome using your display manager:
exec awesome
In order to connect Awesome to a specific display, make sure that
the DISPLAY
environment variable is set correctly, e.g.:
DISPLAY=foo.bar:1 exec awesome
(This will start Awesome on display :1
of the host foo.bar.)
Configuration
The configuration of Awesome is done by creating a
$XDG_CONFIG_HOME/awesome/rc.lua
file, typically ~/.config/awesome/rc.lua
.
An example configuration named awesomerc.lua
is provided in the source.
Troubleshooting
On most systems any message printed by Awesome (including warnings and errors)
is written to ~/.xsession-errors
.
If Awesome does not start or the configuration file is not producing the desired results the user should examine this file to gain insight into the problem.
Debugging tips
You can call awesome
with gdb
like this:
DISPLAY=:2 gdb awesome
Then in gdb
set any arguments and run it:
(gdb) set args --replace
(gdb) run
Asking questions
IRC
You can join us in the #awesome
channel on the OFTC IRC network.
Stack Overflow
You can ask questions on Stack Overflow.
We also have a awesome subreddit where you can share your work and ask questions.
Reporting issues
Please report any issues you may find on our bugtracker.
Contributing code
You can submit pull requests on the github repository. Please read the contributing guide for any coding, documentation or patch guidelines.
Status
Documentation
Online documentation is available here.
License
The project is licensed under GNU General Public License v2 or later. You can read it online at (v2 or v3).