From 7a4c3345fbd181b53af1473f09735c202827438e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrej=20Kou=C5=99il?= Date: Wed, 23 Mar 2016 18:57:05 +0100 Subject: [PATCH 1/7] Update bat.lua --- widgets/bat.lua | 195 +++++++++++++++++++++++------------------------- 1 file changed, 93 insertions(+), 102 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index a6a8b4f..b118035 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -1,10 +1,10 @@ --[[ - - Licensed under GNU General Public License v2 - * (c) 2013, Luke Bonham - * (c) 2010-2012, Peter Hofmann - + + Licensed under GNU General Public License v2 + * (c) 2013, Luke Bonham + * (c) 2010-2012, Peter Hofmann + --]] local newtimer = require("lain.helpers").newtimer @@ -23,119 +23,110 @@ local setmetatable = setmetatable -- lain.widgets.bat local function worker(args) - local bat = {} - local args = args or {} - local timeout = args.timeout or 30 - local battery = args.battery or "BAT0" - local ac = args.ac or "AC0" - local notify = args.notify or "on" - local settings = args.settings or function() end + local bat = {} + local args = args or {} + local timeout = args.timeout or 30 + local battery = args.battery or "BAT0" + local ac = args.ac or "AC0" + local notify = args.notify or "on" + local settings = args.settings or function() end - bat.widget = wibox.widget.textbox('') + bat.widget = wibox.widget.textbox('') - bat_notification_low_preset = { - title = "Battery low", - text = "Plug the cable!", - timeout = 15, - fg = "#202020", - bg = "#CDCDCD" - } + bat_notification_low_preset = { + title = "Battery low", + text = "Plug the cable!", + timeout = 15, + fg = "#202020", + bg = "#CDCDCD" + } - bat_notification_critical_preset = { - title = "Battery exhausted", - text = "Shutdown imminent", - timeout = 15, - fg = "#000000", - bg = "#FFFFFF" - } + bat_notification_critical_preset = { + title = "Battery exhausted", + text = "Shutdown imminent", + timeout = 15, + fg = "#000000", + bg = "#FFFFFF" + } - function update() - bat_now = { - status = "Not present", - ac_status = "N/A", - perc = "N/A", - time = "N/A", - watt = "N/A" - } + function update() + bat_now = { + status = "Not present", + ac_status = "N/A", + perc = "N/A", + time = "N/A", + watt = "N/A" + } - local bstr = "/sys/class/power_supply/" .. battery - local present = first_line(bstr .. "/present") + local bstr = "/sys/class/power_supply/" .. battery + local astr = "/sys/class/power_supply/" .. ac + local present = first_line(bstr .. "/present") - if present == "1" - then - local ratep = tonumber(first_line(bstr .. "/power_now")) - local ratec = tonumber(first_line(bstr .. "/current_now")) - local ratev = tonumber(first_line(bstr .. "/voltage_now")) + if present == "1" + then + -- current_now(I)[uA], voltage_now(U)[uV], power_now(P)[uW] + local rate_current = tonumber(first_line(bstr .. "/current_now")) + local rate_voltage = tonumber(first_line(bstr .. "/voltage_now")) + local rate_power = tonumber(first_line(bstr .. "/power_now")) - local rem = tonumber(first_line(bstr .. "/energy_now") or - first_line(bstr .. "/charge_now")) + -- energy_now(P)[uWh], charge_now(I)[uAh] + local energy_now = tonumber(first_line(bstr .. "/energy_now") or + first_line(bstr .. "/charge_now")) + + -- energy_full(P)[uWh], charge_full(I)[uAh], + local energy_full = tonumber(first_line(bstr .. "/energy_full") or + first_line(bstr .. "/charge_full")) - local tot = tonumber(first_line(bstr .. "/energy_full") or - first_line(bstr .. "/charge_full")) - bat_now.status = first_line(bstr .. "/status") or "N/A" - bat_now.ac_status = first_line(string.format("/sys/class/power_supply/%s/online", ac)) or "N/A" + local energy_percentage = tonumber(first_line(bstr .. "/capacity")) or + math.floor((energy_now / energy_full) * 100) - local time_rat = 0 - if bat_now.status == "Charging" - then - time_rat = (tot - rem) / (ratep or ratec) - elseif bat_now.status == "Discharging" - then - time_rat = rem / (ratep or ratec) - end + bat_now.status = first_line(bstr .. "/status") or "N/A" + bat_now.ac_status = first_line(astr .. "/online") or "N/A" - local hrs = math.floor(time_rat) - if hrs < 0 then hrs = 0 elseif hrs > 23 then hrs = 23 end + local rate_time = 0 + if bat_now.status == "Charging" + then + rate_time = (energy_full - energy_now) / rate_power or rate_current + elseif bat_now.status == "Discharging" + then + rate_time = energy_now / rate_power or rate_current + end - local min = math.floor((time_rat - hrs) * 60) - if min < 0 then min = 0 elseif min > 59 then min = 59 end + local hours = math.floor(rate_time) + local minutes = math.floor((rate_time - hours) * 60) - bat_now.time = string.format("%02d:%02d", hrs, min) + bat_now.perc = string.format("%d", energy_percentage) + bat_now.time = string.format("%02d:%02d", hours, minutes) + bat_now.watt = string.format("%.2fW", rate_power / 1e6 or (rate_voltage * rate_current) / 1e12) + + end + widget = bat.widget + settings() - local perc = tonumber(first_line(bstr .. "/capacity")) or math.floor((rem / tot) * 100) + -- notifications for low and critical states + if bat_now.status == "Discharging" and notify == "on" and bat_now.perc + then + local nperc = tonumber(bat_now.perc) or 100 + if nperc <= 5 + then + bat.id = naughty.notify({ + preset = bat_notification_critical_preset, + replaces_id = bat.id, + }).id + elseif nperc <= 15 + then + bat.id = naughty.notify({ + preset = bat_notification_low_preset, + replaces_id = bat.id, + }).id + end + end + end - if perc <= 100 then - bat_now.perc = string.format("%d", perc) - elseif perc > 100 then - bat_now.perc = "100" - elseif perc < 0 then - bat_now.perc = "0" - end + newtimer(battery, timeout, update) - if ratep then - bat_now.watt = string.format("%.2fW", ratep) - else - bat_now.watt = string.format("%.2fW", (ratev * ratec) / 1e12) - end - end - - widget = bat.widget - settings() - - -- notifications for low and critical states - if bat_now.status == "Discharging" and notify == "on" and bat_now.perc - then - local nperc = tonumber(bat_now.perc) or 100 - if nperc <= 5 - then - bat.id = naughty.notify({ - preset = bat_notification_critical_preset, - replaces_id = bat.id, - }).id - elseif nperc <= 15 - then - bat.id = naughty.notify({ - preset = bat_notification_low_preset, - replaces_id = bat.id, - }).id - end - end - end - - newtimer(battery, timeout, update) - - return setmetatable(bat, { __index = bat.widget }) + return setmetatable(bat, { __index = bat.widget }) end return setmetatable({}, { __call = function(_, ...) return worker(...) end }) From 37c4198cdf300b4dab002e5cbc9ea2590f17f168 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrej=20Kou=C5=99il?= Date: Sun, 27 Mar 2016 13:10:14 +0200 Subject: [PATCH 2/7] Added rate check --- widgets/bat.lua | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/widgets/bat.lua b/widgets/bat.lua index b118035..8cc1ea9 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -69,6 +69,13 @@ local function worker(args) local rate_voltage = tonumber(first_line(bstr .. "/voltage_now")) local rate_power = tonumber(first_line(bstr .. "/power_now")) + -- if rate = 0 or rate not defined skip the round + if not (rate_power and rate_power > 0) and + not (rate_current and rate_current > 0) + then + return + end + -- energy_now(P)[uWh], charge_now(I)[uAh] local energy_now = tonumber(first_line(bstr .. "/energy_now") or first_line(bstr .. "/charge_now")) From 2b4e911dfd6ca7fe0fde48ddd095dc70d2c32fe3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrej=20Kou=C5=99il?= Date: Sun, 27 Mar 2016 15:28:52 +0200 Subject: [PATCH 3/7] Added rule for bat_now.status = Full when rate suppose be 0 --- widgets/bat.lua | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/widgets/bat.lua b/widgets/bat.lua index 8cc1ea9..9bd526a 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -91,6 +91,14 @@ local function worker(args) bat_now.status = first_line(bstr .. "/status") or "N/A" bat_now.ac_status = first_line(astr .. "/online") or "N/A" + -- if rate = 0 or rate not defined skip the round + if not (rate_power and rate_power > 0) and + not (rate_current and rate_current > 0) and + not bat_now.status == "Full" + then + return + end + local rate_time = 0 if bat_now.status == "Charging" then From 6e54e1d62a0761d3fc61406ca0419fa94d90eae2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrej=20Kou=C5=99il?= Date: Sun, 27 Mar 2016 15:29:38 +0200 Subject: [PATCH 4/7] Removed forgotten previous rate rule. --- widgets/bat.lua | 7 ------- 1 file changed, 7 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index 9bd526a..9ab4ce6 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -69,13 +69,6 @@ local function worker(args) local rate_voltage = tonumber(first_line(bstr .. "/voltage_now")) local rate_power = tonumber(first_line(bstr .. "/power_now")) - -- if rate = 0 or rate not defined skip the round - if not (rate_power and rate_power > 0) and - not (rate_current and rate_current > 0) - then - return - end - -- energy_now(P)[uWh], charge_now(I)[uAh] local energy_now = tonumber(first_line(bstr .. "/energy_now") or first_line(bstr .. "/charge_now")) From fcbb371e56561c94cde3e8c52a725524c70fb1d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrej=20Kou=C5=99il?= Date: Mon, 28 Mar 2016 17:22:40 +0200 Subject: [PATCH 5/7] forgoten brackets at rule --- widgets/bat.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index 9ab4ce6..61ad6a3 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -85,11 +85,11 @@ local function worker(args) bat_now.ac_status = first_line(astr .. "/online") or "N/A" -- if rate = 0 or rate not defined skip the round - if not (rate_power and rate_power > 0) and + if not (rate_power and rate_power > 0) and not (rate_current and rate_current > 0) and - not bat_now.status == "Full" + not (bat_now.status == "Full") then - return + return end local rate_time = 0 From 27fc95570cce74f4f0ea086d51951f0df38abe5b Mon Sep 17 00:00:00 2001 From: Luke Bonham Date: Thu, 31 Mar 2016 11:54:37 +0200 Subject: [PATCH 6/7] bat: replaced tabs with spaces and removed whitespaces --- widgets/bat.lua | 51 ++++++++++++++++++++++--------------------------- 1 file changed, 23 insertions(+), 28 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index 61ad6a3..d84883e 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -34,19 +34,19 @@ local function worker(args) bat.widget = wibox.widget.textbox('') bat_notification_low_preset = { - title = "Battery low", - text = "Plug the cable!", + title = "Battery low", + text = "Plug the cable!", timeout = 15, - fg = "#202020", - bg = "#CDCDCD" + fg = "#202020", + bg = "#CDCDCD" } bat_notification_critical_preset = { - title = "Battery exhausted", - text = "Shutdown imminent", + title = "Battery exhausted", + text = "Shutdown imminent", timeout = 15, - fg = "#000000", - bg = "#FFFFFF" + fg = "#000000", + bg = "#FFFFFF" } function update() @@ -69,20 +69,20 @@ local function worker(args) local rate_voltage = tonumber(first_line(bstr .. "/voltage_now")) local rate_power = tonumber(first_line(bstr .. "/power_now")) - -- energy_now(P)[uWh], charge_now(I)[uAh] + -- energy_now(P)[uWh], charge_now(I)[uAh] local energy_now = tonumber(first_line(bstr .. "/energy_now") or - first_line(bstr .. "/charge_now")) - - -- energy_full(P)[uWh], charge_full(I)[uAh], + first_line(bstr .. "/charge_now")) + + -- energy_full(P)[uWh], charge_full(I)[uAh], local energy_full = tonumber(first_line(bstr .. "/energy_full") or - first_line(bstr .. "/charge_full")) + first_line(bstr .. "/charge_full")) local energy_percentage = tonumber(first_line(bstr .. "/capacity")) or - math.floor((energy_now / energy_full) * 100) + math.floor((energy_now / energy_full) * 100) - bat_now.status = first_line(bstr .. "/status") or "N/A" - bat_now.ac_status = first_line(astr .. "/online") or "N/A" + bat_now.status = first_line(bstr .. "/status") or "N/A" + bat_now.ac_status = first_line(astr .. "/online") or "N/A" -- if rate = 0 or rate not defined skip the round if not (rate_power and rate_power > 0) and @@ -91,13 +91,11 @@ local function worker(args) then return end - + local rate_time = 0 - if bat_now.status == "Charging" - then + if bat_now.status == "Charging" then rate_time = (energy_full - energy_now) / rate_power or rate_current - elseif bat_now.status == "Discharging" - then + elseif bat_now.status == "Discharging" then rate_time = energy_now / rate_power or rate_current end @@ -107,23 +105,20 @@ local function worker(args) bat_now.perc = string.format("%d", energy_percentage) bat_now.time = string.format("%02d:%02d", hours, minutes) bat_now.watt = string.format("%.2fW", rate_power / 1e6 or (rate_voltage * rate_current) / 1e12) - end + widget = bat.widget settings() -- notifications for low and critical states - if bat_now.status == "Discharging" and notify == "on" and bat_now.perc - then + if bat_now.status == "Discharging" and notify == "on" and bat_now.perc then local nperc = tonumber(bat_now.perc) or 100 - if nperc <= 5 - then + if nperc <= 5 then bat.id = naughty.notify({ preset = bat_notification_critical_preset, replaces_id = bat.id, }).id - elseif nperc <= 15 - then + elseif nperc <= 15 then bat.id = naughty.notify({ preset = bat_notification_low_preset, replaces_id = bat.id, From da3310b775a0b421302bc95a616ec4bb4cdb4a60 Mon Sep 17 00:00:00 2001 From: Luke Bonham Date: Thu, 31 Mar 2016 12:00:47 +0200 Subject: [PATCH 7/7] alsa: some indentation --- widgets/alsa.lua | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/widgets/alsa.lua b/widgets/alsa.lua index dba20e7..d85a080 100644 --- a/widgets/alsa.lua +++ b/widgets/alsa.lua @@ -7,15 +7,15 @@ --]] -local newtimer = require("lain.helpers").newtimer -local read_pipe = require("lain.helpers").read_pipe +local newtimer = require("lain.helpers").newtimer +local read_pipe = require("lain.helpers").read_pipe -local wibox = require("wibox") +local wibox = require("wibox") -local string = { match = string.match, - format = string.format } +local string = { match = string.match, + format = string.format } -local setmetatable = setmetatable +local setmetatable = setmetatable -- ALSA volume -- lain.widgets.alsa @@ -32,11 +32,11 @@ local function worker(args) function alsa.update() mixer = read_pipe(string.format("%s get %s", alsa.cmd, alsa.channel)) - l, s = string.match(mixer, "([%d]+)%%.*%[([%l]*)") + l,s = string.match(mixer, "([%d]+)%%.*%[([%l]*)") if alsa.last_level ~= l or alsa.last_status ~= s then volume_now = { level = l, status = s } - alsa.last_level = l + alsa.last_level = l alsa.last_status = s widget = alsa.widget @@ -45,7 +45,6 @@ local function worker(args) end timer_id = string.format("alsa-%s-%s", alsa.cmd, alsa.channel) - newtimer(timer_id, timeout, alsa.update) return setmetatable(alsa, { __index = alsa.widget })