As this was the last step in the base constructor, it could be
done in each menu type without the callback and extra code.
The only reason this existed was to allow menu "sub classes"
that override this function. However, since this was rewritten,
it was no longer used, so for the sake of simplicity, I remove
this feature.
This is a step forward to stabilize Radical again. Most of impl/ and widgets/
code is still a mess, but the other modules slowly start to be maintainable
again. The road is still long before the Radical code is good enough to go
into Awesome. It will get there, eventually.
The menu can be attached to a widget or the mouse again, and more
This commit also fix some tasklist/taglist issues and introduce minor
features like item.shape.
There is a new widget called `infoshapes`. It support all the features
from the underlay system, but is a lot less intrusive. This allow to
make some code simpler.
This is another step in getting rid of all the hacks.
Radical is a model-view framework. There is a common API to
set data, then view modules to display it. Those modules have
been rewritten on top of new APIs.
Not all features are yet re-integrated, most are. Future commits
will address the various regressions and missing features. This
time, the code should be maintainable. The whole separation of
concerns analysis has been re-done. Allowing code de-duplication
and generalization.
The API remain the same, only `set_menu` has changed a little to
allow merging the 2 sub-menu code paths.
This commit begin to merge the Radical "view" rewrite.
Those module API replace previously hardcoded positioning
logic. Some code may eventually be upstreamed once mature
enough.
These commits dont make the code any smaller or more readable by
themselves. However, they are one step along many to refactor the
code to become more readable and simpler.
Eventual addition will extend the declarative syntax and merge it
with Radical own syntax (this will break the API a little due to
naming conflitcs).
I will also split the theme details from the declarative syntax and
use a separate "chain of responsability" meta-object to handle it.
Lots of things will break, hopefully for the better (eventually)
This commit use new upstream APIs:
* Many cairo paths have been replaced with gears.shape and gears.matrix
This commit add some features:
* Improved border_color support, now available per state
* bg_image support, now available per state
* Mutualize the state setting, remove duplicated code
Regressions:
* The arrow menu background border is off by a pixel
* The layout position problem reported by @mindeunix is now worst.
The positioning algo is full of race conditions and cannot be fixed
without a full rewrite. This commit break more things than it solve
and the code is in the middle of a transition. This will be solved
by future commits addressing the code quality (after the refactoring).
The position of the drawable wasn't taken into account.
This does not fix the bug reported by Minde where the manu
position is correct the first time, but off the second, this is
due to something else.
**WARNING**: this break the API
menu.overlay -> menu.draw_overlay
The new "overlay" behave like underlay, but is on top
This commit also add underlay/overlay "align" option and document
the feature properly.
The "hack" force the full redraw of the menu. This is what 3.5 did
anyway, but of course is not correct. The new layout system allow
widgets to have a larger fit and it should cascade by itself. This
is not yet used by radical.
This commit also fix some mistake made during the initial port.
My whole config now load mostly correctly. Some 3.5 era bugs even
fixed themselves! It is still slower for some reasons and have many
errors left, but it "look" ok.
This is the first step toward removing the underlay/overlay from
all item.style and item.layout and use the common implementation.
This will simplify the code a lot.
This commit fix most issues introduced by the new widget system. It
is not production ready and will require multiple commits to fix
individual issues.
The new widget system is better suited for modules like Radical than
the previous one. Over time, this breakage will probably end up being
a good thing. However, for now, expect multiple errors.
The changes:
* The draw "wibox" argument is now a "context". "context.wibox" is
the equivalent. This will allow passing the Radical structure to
the draw method without storing it in the widgets.
* "fit" now have a new required "context" argument for the DPI, this
will allow removing the "default_height" variable Radical is using
to scale the UI on HIDPI systems. This will allow size policies to
be passed to the fit method
* "draw" has been splitted into "draw", "draw_before_children",
"draw_after_children" and "layout". This simplify the overlay
system and will allow cleaner code
* Drawing outside of the widget clip is no longer supported, this
break multiple Radical item.style. This will allow better
performance and less redraw once the new system issues have been
fixed
Emmanuel Lepage Vallee
minde