awesomewm-mirrors
/
awesome
mirror of https://github.com/awesomeWM/awesome.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Cleanup of TODO messages

This commit is contained in:
Arnaud Fontaine 2008-03-28 21:59:05 +00:00 committed by Julien Danjou
parent d2d85941ad
commit 1309287ead
3 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
event.c
View File

@ -579,9 +579,9 @@ event_handle_randr_screen_change_notify(void *data __attribute__ ((unused)),
xcb_randr_set_screen_size(connection, ev->root, ev->width, ev->height, xcb_randr_set_screen_size(connection, ev->root, ev->width, ev->height,
ev->mwidth, ev->mheight); ev->mwidth, ev->mheight);
/* TODO: /* XRRUpdateConfiguration also executes the following instruction
* XRRUpdateConfiguration also executes the following instruction * but it's not useful because SubpixelOrder is not used at all at
* but I don't know yet how to port it to XCB * the moment
* *
* XRenderSetSubpixelOrder(dpy, snum, scevent->subpixel_order); * XRenderSetSubpixelOrder(dpy, snum, scevent->subpixel_order);
*/ */

4
ewmh.c
View File

@ -357,7 +357,6 @@ ewmh_process_client_message(xcb_client_message_event_t *ev)
Client *c; Client *c;
int screen; int screen;
/* TODO: check whether it's correct to use 'type' this way */
if(ev->type == net_current_desktop) if(ev->type == net_current_desktop)
for(screen = 0; for(screen = 0;
screen < xcb_setup_roots_length(xcb_get_setup(globalconf.connection)); screen < xcb_setup_roots_length(xcb_get_setup(globalconf.connection));
@ -377,9 +376,6 @@ ewmh_process_client_message(xcb_client_message_event_t *ev)
if((c = client_get_bywin(globalconf.clients, ev->window))) if((c = client_get_bywin(globalconf.clients, ev->window)))
{ {
ewmh_process_state_atom(c, (xcb_atom_t) ev->data.data32[1], ev->data.data32[0]); ewmh_process_state_atom(c, (xcb_atom_t) ev->data.data32[1], ev->data.data32[0]);
/* TODO: is data32[2] really useful because it doesn't
* seem to be used when sending a ClientMessage in
* event.c:897 */
if(ev->data.data32[2]) if(ev->data.data32[2])
ewmh_process_state_atom(c, (xcb_atom_t) ev->data.data32[2], ewmh_process_state_atom(c, (xcb_atom_t) ev->data.data32[2],
ev->data.data32[0]); ev->data.data32[0]);

14
mouse.c
View File

@ -191,11 +191,8 @@ uicb_client_movemouse(int screen, char *arg __attribute__ ((unused)))
for(;;) for(;;)
{ {
/* TODO: need a review /* XMaskEvent allows to retrieve only specified events from
* * the queue and requeue the other events... */
* XMaskEvent allows to retrieve only specified events from
* the queue and requeue the other events...
*/
while((ev = xcb_poll_for_event(globalconf.connection))) while((ev = xcb_poll_for_event(globalconf.connection)))
{ {
switch((ev->response_type & 0x7f)) switch((ev->response_type & 0x7f))
@ -389,11 +386,8 @@ uicb_client_resizemouse(int screen, char *arg __attribute__ ((unused)))
for(;;) for(;;)
{ {
/* TODO: need a review /* XMaskEvent allows to retrieve only specified events from
* * the queue and requeue the other events... */
* XMaskEvent allows to retrieve only specified events from
* the queue and requeue the other events...
*/
while((ev = xcb_poll_for_event(globalconf.connection))) while((ev = xcb_poll_for_event(globalconf.connection)))
{ {
switch((ev->response_type & 0x7f)) switch((ev->response_type & 0x7f))