Commit Graph

10631 Commits

Author SHA1 Message Date
Emmanuel Lepage Vallee 9dcfde32e0 naughty: Never hold a strong reference to the notification in the box.
luajit was failing to GC the notification about 5% of the time. This
commit stores all widget notifications in a weak table and don't let
any lambda access the parent object notification object.

Each of those changes reduces the failure rate. There might still be
a couple in there, but the test passed 200x on my laptop with 100%
success rate.
2021-10-31 19:30:17 -07:00
Emmanuel Lepage Vallee 6e8b0d5a85 ci: Be faster. 2021-10-31 13:37:33 -07:00
Emmanuel Lepage Vallee 295538e389 tests: Force GTK3 for the client test.
GTK4 removes iconify and deiconify and replaces them with
minimize and unminimize.
2021-10-31 13:37:33 -07:00
Emmanuel Lepage Vallee a08191913e tests: Blind attempt at making a flacky test under luajit stable.
I could not reproduce the issue locally.
2021-10-31 13:37:33 -07:00
Emmanuel Lepage Vallee 90a2b003a2 tests: Remove a noisy print 2021-10-31 13:37:33 -07:00
Emmanuel Lepage Vallee b4beb2308b tests: Add a simple systray test.
Compile a random little C program found on stack overflow to make
a systray. The goal is to make the `event.c` tests less flacky.
2021-10-31 13:37:32 -07:00
Uli Schlachter 4955ec584f tests: Add a systray program. 2021-10-31 13:36:17 -07:00
Emmanuel Lepage Vallee 6c1f2aac5b tests: Emulate some clicks on the titlebars.
Maybe it will make the test coverage more deterministic... or not.
2021-10-29 17:35:44 -07:00
Emmanuel Lepage Vallee 15f63c700c tests: Add size changes to the `xeyes` test.
It should trigger some shape related code in the core which wasn't
hit reliably until now.
2021-10-29 17:35:44 -07:00
Emmanuel Lepage Vallee 6615772d10 tests: Extend the test client to handle minimization.
The goal is to make the coverage less flacky by explicitly
handling some events.
2021-10-28 22:11:21 -07:00
Emmanuel Lepage Vallée 50b9b10437
texrbox: Fix a recent regression. (#3488)
The intial font wasn't set.
2021-10-28 19:24:49 -07:00
Emmanuel Lepage Vallée 1e0d1e7ba9
Merge pull request #3466 from Elv13/fix_3428
Fix a regression in naughty.notification.ignore_suspend
2021-10-28 12:27:42 -07:00
Emmanuel Lepage Vallée d5fae3f3dc
Merge pull request #3478 from Elv13/better_shims
Fix a few sequences template bugs
2021-10-28 12:27:11 -07:00
Emmanuel Lepage Vallée c8ada80fb3
Merge pull request #3484 from Elv13/2012_misc_fixes
Miscellaneous small bug fixes
2021-10-28 12:26:47 -07:00
Emmanuel Lepage Vallée 85dc78520a
Merge pull request #3485 from ezz666/ldoc_readonly_tag
Ldoc readonly tag
2021-10-28 12:25:45 -07:00
Emmanuel Lepage Vallée 9595dc38d2
Remove coveralls. (#3486)
It's inferior to codecov and I am not aware of anyone who will miss
it.
2021-10-28 12:24:59 -07:00
Emmanuel Lepage Vallée b6f4c85ba6
tests: Restructure the wibar test to work better on luajit. (#3487)
There were too many references to the original wibar and the GC
cannot resolve them 50% of the time. As shown in test-leak, GCing
the wibar does work. Just not the way the test was strutured.
2021-10-28 12:24:37 -07:00
Emmanuel Lepage Vallee 4f645fd07f tests: Kill the test-selection-getter clients.
This removes a confusing warning in the CI logs.
2021-10-27 20:08:15 -07:00
Emmanuel Lepage Vallee bb65181e61 doc: Document the textbox font. 2021-10-27 20:08:15 -07:00
Emmanuel Lepage Vallee cdd50feea7 tests: Test the client border color and width. 2021-10-27 20:08:15 -07:00
Emmanuel Lepage Vallee 5069f5c2ed client.floating: Add a missing signal connection.
The `fullscreen` state does affect the outcome of the state, so
it needs to be connected for request::border to be sent.
2021-10-27 20:08:15 -07:00
Emmanuel Lepage Vallee cd83b64268 tests: Test titlebar fonts. 2021-10-27 20:08:15 -07:00
Emmanuel Lepage Vallee a3c7ed166f tests: Modify the client.relative_move test for the new behavior.
Also add more asserts.
2021-10-27 19:50:48 -07:00
Emmanuel Lepage Vallee 7d6892992c client: Change the `relative_move` behavior.
The old behavior would move the client when `nil` was passed by
an almost arbitrary value. It would most of the time go off screen.

While this is a behavior change, what it replaces was so broken I
doubt anybody actually used `nil` in `relative_move`.
2021-10-27 18:30:30 -07:00
Emmanuel Lepage Vallee 8c9e270477 tests: Improve the sequence template.
* Fix a typo
 * Add some initialization signals
 * Refactor the geometry code to be more resilient
 * Put more data into the memento
2021-10-27 18:30:30 -07:00
Emmanuel Lepage Vallee 94e13b7bb0 shims: Fix some bugs for ruled.tag. 2021-10-27 18:30:30 -07:00
Emmanuel Lepage Vallee 146a9c3166 permission: Fix hiding the border for maximized clients.
When the theme variables were moved to the backend instead of `rc.lua`,
some magic was added to disable them if the user set the border. However,
some undocumented `awful.placement` code also set them and turned off
the theme variables. So it worked *once* then stopped working.
2021-10-27 13:41:11 -07:00
Emmanuel Lepage Vallee 907053f31a titlebar: Implement setting the font (as documented, but unimplemented)
It was documented to exist, but didn't.
2021-10-27 13:41:11 -07:00
Emmanuel Lepage Vallee c36a869ded textbox: Store the font in `_private`.
So a getter can work.
2021-10-27 13:41:11 -07:00
Emmanuel Lepage Vallee c7208b4bb0 layoutlist: Rename the constructor arg from `layout` to `base_layout`.
The documentation examples already called it that way.
2021-10-27 13:41:11 -07:00
Emmanuel Lepage Vallee 440d1560a3 layoutlist: Fix the `layout` consturctor parameter.
If set, it would override some important widget methods and
explode.
2021-10-27 13:41:10 -07:00
Emmanuel Lepage Vallee 2f8413acbc layoutlist: Use `layoutlist_spacing` instead of `tasklist_spacing`.
Old copy/paste bug.
2021-10-27 13:38:48 -07:00
Sergey fcef95b1f0 Removing duplicating descriptions of screen properties as read only
Removed "Immutable: true" from readonly properties descriptions.
2021-10-27 14:52:36 -04:00
Sergey 212ec72236 Removing read only from properties descriptions. It's set with ldoc tag now. 2021-10-27 14:52:36 -04:00
Sergey 6c3d233893 Mark readonly properties for screen 2021-10-27 14:52:36 -04:00
Sergey 43ff4e07ad Marking readonly properties for client 2021-10-27 14:52:36 -04:00
Sergey 6a92af1662 Adding readonly tag to the summary 2021-10-27 14:52:25 -04:00
Sergey 486fd3744f Adding ldoc readonly tag text in the extra_summary list 2021-10-26 18:31:45 -04:00
Sergey 899f9c8879 Adding readonly ldoc tag 2021-10-26 18:07:20 -04:00
Sergey 60dfa3f6bd Fixing a typo 2021-10-26 18:06:38 -04:00
Emmanuel Lepage Vallee c63a80de5c layoutlist: Allow empty constructor. 2021-10-26 13:37:16 -07:00
Emmanuel Lepage Vallee 11e4fe88bb client.border_color: Fix a bug affecting floating clients.
If client client was tiled, the `fallback` could be
`theme.border_color_normal`, but if the client was
tiled, this fallback was never tried.

Now it tests for both "floating" and "active" fallbacks.

This problem actually affects the default theme.
2021-10-26 13:37:16 -07:00
paulhersch ebc9b99ae2
fixed a typo (#3481) 2021-10-23 20:02:34 -07:00
Emmanuel Lepage Vallée 1e6f213bcf
Merge pull request #3477 from Elv13/fix_matcher
Fix a gears.matcher bug and add a small feature.
2021-10-23 12:15:29 -07:00
Emmanuel Lepage Vallée a1716a7edc
Merge pull request #3462 from Aire-One/fix/3458
Fix 3458
2021-10-22 23:27:55 -07:00
Emmanuel Lepage Vallee ffb95eec8d tests: Improve gears.matcher tests. 2021-10-22 23:13:26 -07:00
Emmanuel Lepage Vallee 9db62b824c gears.matcher: Add `fallback` rules.
Right now, all rules are additive, they are squashed into one big
array of properties. This is normally fine, but sometime you want
explicit rules for some objects, but also default rules if nothing
matches.

While this can be expressed in the current system by overriding
*all* properties, this require more effort than having "special"
and "fallback" rules.
2021-10-22 22:26:12 -07:00
Emmanuel Lepage Vallee 005c2d61a0 gears.matcher: Fix `rule_every`.
It really didn't do the right thing and didn't work anyway.
2021-10-22 22:26:12 -07:00
Emmanuel Lepage Vallée 8541637a85
Merge pull request #3475 from Elv13/fix_626
Another doc upgrade.
2021-10-21 15:07:54 -07:00
Emmanuel Lepage Vallee b2603f6a86 doc: Add images for awful.client.* functions. 2021-10-18 14:38:37 -07:00